MVPoly/prime: implement compute_cross_terms #2502
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/implement-compute-cross-terms
branch
from
d977ac4
to
bb7257e
Compare
dannywillems
force-pushed
the
dw/implement-compute-cross-terms
branch
from
bb7257e
to
0db433f
Compare
dannywillems
changed the base branch from
master
to
dw/mvpoly-test-is-constant
marcbeunardeau88
approved these changes
Aug 29, 2024
dannywillems
force-pushed
the
dw/mvpoly-test-is-constant
branch
from
03ac16b
to
0918cda
Compare
dannywillems
force-pushed
the
dw/implement-compute-cross-terms
branch
2 times, most recently
from
82a5a82
to
173dfb0
Compare
dannywillems
changed the base branch from
master
to
dw/compute-indices-nested-loops
dannywillems
force-pushed
the
dw/implement-compute-cross-terms
branch
5 times, most recently
from
74f6f1f
to
d3474da
Compare
It will be used later in the cross-term computation to perform the multi-nomial sum
dannywillems
force-pushed
the
dw/compute-indices-nested-loops
branch
from
dc8d41c
to
8c5f8b8
Compare
dannywillems
force-pushed
the
dw/implement-compute-cross-terms
branch
from
d3474da
to
2a0aa24
Compare
dannywillems
force-pushed
the
dw/compute-indices-nested-loops
branch
from
8c5f8b8
to
d11c543
Compare
Fizzixnerd
reviewed
Sep 9, 2024
| eval2: &[F; N], | ||
| u1: F, | ||
| u2: F, | ||
| ) -> HashMap<usize, F> { |
There was a problem hiding this comment.
Maybe this is a dumb question, but I don't understand why we use a HashMap here instead of just a Vector.
There was a problem hiding this comment.
Just noticed this is still draft. Sorry. Feel free to resolve.
dannywillems
changed the title
|
Leaving like this for now, as focusing on monomials form and Arrabiata for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.