Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arkworks to 0.4.2 (master) #2588

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

volhovm
Copy link
Member

@volhovm volhovm commented Sep 20, 2024

Main part of update (towards develop = mina's compatible) has been done here: MinaProtocol/mina#15940

This upgrades master too. It's non-trivial since master has a lot of stuff develop doesn't.

@volhovm volhovm force-pushed the volhovm/arkworks042-develop branch 2 times, most recently from bca9769 to 1b051ee Compare September 20, 2024 18:49
chiro-hiro and others added 2 commits September 20, 2024 19:51
…ible)

Update arkworks to 0.4.2 for pallas and vesta

Update test cases to new version of test suite 0.4.2

Upgrade utils to arkworks 0.4.2

Upgrade poseidon to arkworks 0.4.2

Upgrade export test vectors of poseidon to arkworks 0.4.2

Upgrade groupmap to arkworks 0.4.2

Upgrade hasher to arkworks 0.4.2

Upgrade signer to arkworks 0.4.2

Upgrade turshi to arkworks 0.4.2

Convert poly-comm to arkworks 0.4.2

Upgrade arkworks for `kimchi` and other libraries/tools

Fixup compilation errors in OCaml conversion helpers

Adjust serde_as regression test to 0.4.2

Use compressed serialization

Fix erroneous implicit Affine->Proj conversions

Fix from_address bug

Fix ocaml printing: use hex instead of integer
@volhovm volhovm marked this pull request as ready for review September 20, 2024 18:55
@volhovm volhovm marked this pull request as draft September 20, 2024 21:11
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 65.52795% with 111 lines in your changes missing coverage. Please review.

Project coverage is 71.13%. Comparing base (0583e99) to head (e0d92f4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
poly-commitment/src/combine.rs 13.11% 53 Missing ⚠️
curves/src/pasta/fields/mod.rs 0.00% 10 Missing ⚠️
poly-commitment/src/commitment.rs 64.28% 10 Missing ⚠️
kimchi/src/curve.rs 63.15% 7 Missing ⚠️
poseidon/export_test_vectors/src/vectors.rs 0.00% 5 Missing ⚠️
curves/src/pasta/curves/pallas.rs 0.00% 4 Missing ⚠️
curves/src/pasta/curves/vesta.rs 0.00% 4 Missing ⚠️
kimchi/src/snarky/folding.rs 0.00% 4 Missing ⚠️
arrabiata/src/prover.rs 0.00% 2 Missing ⚠️
folding/src/expressions.rs 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2588      +/-   ##
==========================================
+ Coverage   70.95%   71.13%   +0.17%     
==========================================
  Files         240      242       +2     
  Lines       57669    57494     -175     
==========================================
- Hits        40919    40898      -21     
+ Misses      16750    16596     -154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants