[easy] Fix lower bound of zk rows for chunking #2590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When chunking is in place, the number of rows reserved for zero knowledge must be augmented accordingly. In particular,
that means that
zk_rows
must at least be(2 * permuts * chunks - 2) / 7 + 1
or what's equivalent, (2 * permuts * chunks - 5) / 7. Examples of this are here.Nonetheless, on the Kimchi side, the strict lower bound
(2 * permuts * chunks - 2) / 7
is created here and is used incorrectly when triggering the error messageProverError::NotZeroKnowledge
. Meaning, it is raised whenever the number of rows is smaller than that value, when it should be raised anytime it is smaller or equal (because by definition, the number of rows must be larger than that value).This PR fixes that mismatch and adapts the error message accordingly.
Example:
With 2 chunks, the message used to read
there are not enough random rows to achieve zero-knowledge (expected: 4, got: 3)
whereas with 2 chunks you need at least 5 rows for zero knowledge.Partially addresses o1-labs/o1js#1806