Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poly-commitment: rename elems into chunks [develop] - DON'T MERGE #2673

Closed
wants to merge 1 commit into from

Conversation

dannywillems
Copy link
Member

Backporting from master
See #2658

@dannywillems dannywillems changed the title Poly-commitment: rename elems into chunks Poly-commitment: rename elems into chunks [develop] Oct 8, 2024
@dannywillems dannywillems changed the title Poly-commitment: rename elems into chunks [develop] Poly-commitment: rename elems into chunks [develop] - DON'T MERGE Oct 9, 2024
Copy link
Member

@volhovm volhovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are just a few other lines that could be /also/ renamed:

ї> git grep elems
poly-commitment/src/commitment.rs:        let elems_size = Iterator::max(com.iter().map(|c| c.chunks.len())).unwrap();
poly-commitment/src/commitment.rs:        let mut chunks = Vec::with_capacity(elems_size);
poly-commitment/src/commitment.rs:        for chunk in 0..elems_size {
poly-commitment/src/srs.rs:    let t = G::BaseField::from_base_prime_field_elems(&base_fields).unwrap();
poly-commitment/src/srs.rs:        let num_elems = (n + srs_size - 1) / srs_size;
poly-commitment/src/srs.rs:        let mut chunks = Vec::with_capacity(num_elems);
poly-commitment/src/srs.rs:        for i in 0..num_elems {
poly-commitment/src/srs.rs:            // Append the 'partial Langrange polynomials' to the vector of elems chunks

@dannywillems
Copy link
Member Author

Closing as it is done in upstream PR #2868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants