Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation for shift right logical immediate riscv32im #2838

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

svv232
Copy link
Member

@svv232 svv232 commented Nov 25, 2024

No description provided.

@svv232 svv232 requested a review from dannywillems November 25, 2024 17:58
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (4ba3d58) to head (26f96e5).
Report is 151 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32im/interpreter.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
- Coverage   72.02%   72.02%   -0.01%     
==========================================
  Files         257      256       -1     
  Lines       60759    60175     -584     
==========================================
- Hits        43761    43340     -421     
+ Misses      16998    16835     -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See same comments than on #2836

@svv232 svv232 requested a review from dannywillems December 11, 2024 16:26
Base automatically changed from sai/shift_left_logical_immediate_riscvi32 to master December 16, 2024 09:59
@dannywillems dannywillems merged commit 08cfecf into master Dec 16, 2024
8 checks passed
@dannywillems dannywillems deleted the sai/shift_right_logical_immediate_riscv32im branch December 16, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants