Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code corrections for updated Rust toolchain #88

Merged
merged 5 commits into from
Jul 6, 2021

Conversation

ltvvlz
Copy link
Contributor

@ltvvlz ltvvlz commented Mar 2, 2021

After updating Rust toolchain with "rustup update", building this repo results in compilation errors. This PR updates the source code to correct compilation.

@ltvvlz ltvvlz requested a review from imeckler March 2, 2021 22:19
@mrmr1993
Copy link
Member

This appears to be due to a breaking change in the rust typechecker rust-lang/rust#79904. I don't think we should take this change until we're set up to migrate our infrastructure to rust >= 1.49.

For now, you should downgrade to a version less than 1.49 (our infra uses 1.45.2) with e.g. rustup toolchain install 1.45.2 && rustup default 1.45.2).

@mrmr1993 mrmr1993 merged commit 79cb600 into master Jul 6, 2021
@mrmr1993 mrmr1993 deleted the corrections-for-updated-rust-toolchain branch July 6, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants