Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: setup: Filter from logs secrets from otopi answer files #47

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

didib
Copy link
Member

@didib didib commented Aug 11, 2022

For details, see oVirt/ovirt-engine#585 .

Change-Id: Ided28013bc854474dc18ec4dfd4e20884945f86c
Signed-off-by: Yedidyah Bar David didi@redhat.com

For details, see oVirt/ovirt-engine#585 .

Change-Id: Ided28013bc854474dc18ec4dfd4e20884945f86c
Signed-off-by: Yedidyah Bar David <didi@redhat.com>
@didib didib requested a review from avlitman as a code owner August 11, 2022 13:05
@avlitman
Copy link
Member

LGTM.
Note that I did not verify this PR only review.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@avlitman
Copy link
Member

@didib Should we wait for the engine patch to be merged first?

@didib
Copy link
Member Author

didib commented Aug 15, 2022

@didib Should we wait for the engine patch to be merged first?

Yes. I talked with @mwperina today and agreed to postpone merging of all of the patches till next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants