Do not merge: Test password filtering #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didib
force-pushed
the
test-password-filtering
branch
2 times, most recently
from
ebea67b
to
7a9f097
Compare
didib
added a commit
to didib/ovirt-engine
that referenced
this pull request
Aug 18, 2022
We currently have two sets of configuration items for PG: One is common to all DBs, another is specific to the engine. Unite them, by moving the engine-specific set to the common one. Cases where this is relevant: 1. Right now, 'engine-backup --mode=restore --provision-all-databases' does not configure the engine-specific items. This causes a next run of 'engine-setup' (which is mandatory) to prompt, asking whether to configure them. 2. Trying to pre-create DBs using provisiondb, like I am now trying [1], leaves postgresql.conf without the engine-specific set. This is worse than in (1.), as the code prompting/asking works only with non-new databases. It's not a real issue for [1] specifically, because I can easily do this there, but decided it's better to patch engine-setup directly. This has no impact on the common case, where all DBs are local, as this configuration is PG-cluster-wide, not DB-specific. The main impact is on DWH running on a separate machine, with the database local to that machine. If the DWH DB is remote, our documentation already instructs to configure all items, not separating to two sets. [1] oVirt/ovirt-system-tests#241 Change-Id: Ief318aa5551cec2d778cf791926518effe404da2 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
added a commit
to didib/ovirt-engine
that referenced
this pull request
Aug 18, 2022
We currently have two sets of configuration items for PG: One is common to all DBs, another is specific to the engine. Unite them, by moving the engine-specific set to the common one. Cases where this is relevant: 1. Right now, 'engine-backup --mode=restore --provision-all-databases' does not configure the engine-specific items. This causes a next run of 'engine-setup' (which is mandatory) to prompt, asking whether to configure them. 2. Trying to pre-create DBs using provisiondb, like I am now trying [1], leaves postgresql.conf without the engine-specific set. This is worse than in (1.), as the code prompting/asking works only with non-new databases. It's not a real issue for [1] specifically, because I can easily do this there, but decided it's better to patch engine-setup directly. This has no impact on the common case, where all DBs are local, as this configuration is PG-cluster-wide, not DB-specific. The main impact is on DWH running on a separate machine, with the database local to that machine. If the DWH DB is remote, our documentation already instructs to configure all items, not separating to two sets. [1] oVirt/ovirt-system-tests#241 Change-Id: Ief318aa5551cec2d778cf791926518effe404da2 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
added a commit
to didib/ovirt-engine
that referenced
this pull request
Aug 18, 2022
We currently have two sets of configuration items for PG: One is common to all DBs, another is specific to the engine. Unite them, by moving the engine-specific set to the common one. Cases where this is relevant: 1. Right now, 'engine-backup --mode=restore --provision-all-databases' does not configure the engine-specific items. This causes a next run of 'engine-setup' (which is mandatory) to prompt, asking whether to configure them. 2. Trying to pre-create DBs using provisiondb, like I am now trying [1], leaves postgresql.conf without the engine-specific set. This is worse than in (1.), as the code prompting/asking works only with non-new databases. It's not a real issue for [1] specifically, because I can easily do this there, but decided it's better to patch engine-setup directly. This has no impact on the common case, where all DBs are local, as this configuration is PG-cluster-wide, not DB-specific. The main impact is on DWH running on a separate machine, with the database local to that machine. If the DWH DB is remote, our documentation already instructs to configure all items, not separating to two sets. [1] oVirt/ovirt-system-tests#241 Change-Id: Ief318aa5551cec2d778cf791926518effe404da2 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
added a commit
to oVirt/ovirt-engine
that referenced
this pull request
Aug 22, 2022
We currently have two sets of configuration items for PG: One is common to all DBs, another is specific to the engine. Unite them, by moving the engine-specific set to the common one. Cases where this is relevant: 1. Right now, 'engine-backup --mode=restore --provision-all-databases' does not configure the engine-specific items. This causes a next run of 'engine-setup' (which is mandatory) to prompt, asking whether to configure them. 2. Trying to pre-create DBs using provisiondb, like I am now trying [1], leaves postgresql.conf without the engine-specific set. This is worse than in (1.), as the code prompting/asking works only with non-new databases. It's not a real issue for [1] specifically, because I can easily do this there, but decided it's better to patch engine-setup directly. This has no impact on the common case, where all DBs are local, as this configuration is PG-cluster-wide, not DB-specific. The main impact is on DWH running on a separate machine, with the database local to that machine. If the DWH DB is remote, our documentation already instructs to configure all items, not separating to two sets. [1] oVirt/ovirt-system-tests#241 Change-Id: Ief318aa5551cec2d778cf791926518effe404da2 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
force-pushed
the
test-password-filtering
branch
3 times, most recently
from
6286568
to
894e6bc
Compare
Change-Id: Ia7df7bb072abaeb2bf3c5c92279547202b8fba3b Signed-off-by: Yedidyah Bar David <didi@redhat.com>
Change-Id: Icf539b9214d03439987e8616f27cb16e0fa0619a Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
force-pushed
the
test-password-filtering
branch
from
894e6bc
to
4fba05e
Compare
|
Not needed anymore, closing. Was created for verifying these: oVirt/otopi#29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I7a066a3315b0ffa70509fdd3af60abecac8cefd4
Signed-off-by: Yedidyah Bar David didi@redhat.com