-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce isolated threads CPUs #260
Conversation
34a5f31
to
df59a90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to propose to rename some of the methods from dedicated to exclusivelyPinned. We've used dedicated as a synonym to exclusively pinned so far but now that we're introducing a new policy we should distinguish them.
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Outdated
Show resolved
Hide resolved
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Outdated
Show resolved
Hide resolved
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
...anager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CpuPinningHelper.java
Show resolved
Hide resolved
...anager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CpuPinningHelper.java
Outdated
Show resolved
Hide resolved
93dac04
to
a5672bb
Compare
/ost |
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good
I think changing 'dedicated' to 'exclusive' makes sense to distinguish that from the dedicated policy as well - changing in all places requires a bit effort so I commented only on some places that I think the benefit would worth it
besides that, I think the only major comment is about how the isolated threads should be sent to the host - if we do it this way, then why should VDSM even know about the policy? something doesn't add up, therefore added @nyoxi
...broker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
Outdated
Show resolved
Hide resolved
...dmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
Outdated
Show resolved
Hide resolved
...dmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
Outdated
Show resolved
Hide resolved
...n/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
Outdated
Show resolved
Hide resolved
...nager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NumaPinningHelper.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
Outdated
Show resolved
Hide resolved
a5672bb
to
5ae080a
Compare
/ost |
5ae080a
to
d60e378
Compare
/ost |
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Outdated
Show resolved
Hide resolved
...nager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NumaPinningHelper.java
Outdated
Show resolved
Hide resolved
...es/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java
Show resolved
Hide resolved
d60e378
to
eb78411
Compare
...bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnit.java
Outdated
Show resolved
Hide resolved
2866c4f
to
ca57089
Compare
/ost |
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Show resolved
Hide resolved
...anager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CpuPinningHelper.java
Outdated
Show resolved
Hide resolved
56ed161
to
0c5eec7
Compare
/ost |
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Show resolved
Hide resolved
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Outdated
Show resolved
Hide resolved
...bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnit.java
Outdated
Show resolved
Hide resolved
...bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnit.java
Outdated
Show resolved
Hide resolved
...anager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CpuPinningHelper.java
Outdated
Show resolved
Hide resolved
...anager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CpuPinningHelper.java
Outdated
Show resolved
Hide resolved
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Outdated
Show resolved
Hide resolved
37cdd67
to
b5b9316
Compare
This patch introduce the logic for isolated threads CpuPinningPolicy. In this policy, each virtual CPU (thread) is taking a whole physical core on the host. These cores are exclusive for the VM to use. Change-Id: I1a3c00ea73f92208725f287c5b6de8d01365a3c0 Bug-Url: https://bugzilla.redhat.com/1782077 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
This patch adds the isolate threads option to the UI. Change-Id: I7b7c095b2acad2f0693f238a2dd3b4c86f9fb63b Bug-Url: https://bugzilla.redhat.com/1782077 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
/ost |
OST failed on UI tests |
This patch introduce the logic for isolated threads CpuPinningPolicy. In
this policy, each virtual CPU (thread) is taking a whole physical core
on the host. These cores are exclusive for the VM to use.
Change-Id: I1a3c00ea73f92208725f287c5b6de8d01365a3c0
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com