Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.adoc #262

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Update README.adoc #262

merged 2 commits into from
Apr 27, 2022

Conversation

aesteve-rh
Copy link
Member

@aesteve-rh aesteve-rh commented Apr 12, 2022

  • Fix links syntax from markdown to asciidoc and remove outdated links.
  • Remove some deprecated Fedora 30 parts and update prerequisites section.

Signed-off-by: Albert Esteve aesteve@redhat.com

@aesteve-rh
Copy link
Member Author

@barpavel @nirs fyi, please review.

@bennyz bennyz requested a review from ArtiomDivak April 12, 2022 13:25
README.adoc Show resolved Hide resolved
@bennyz bennyz mentioned this pull request Apr 12, 2022
README.adoc Outdated Show resolved Hide resolved
@arso
Copy link
Contributor

arso commented Apr 12, 2022 via email

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Show resolved Hide resolved
@bennyz bennyz requested review from sleviim and mkemel April 13, 2022 08:37
README.adoc Show resolved Hide resolved
README.adoc Show resolved Hide resolved
Copy link
Member

@sleviim sleviim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • line 340 - commiting > committing
  • in the Install the following system components: part, Artiom got a new laptop (RHEL CSB) and had to install also the httpd package, maybe worth adding it to the list

README.adoc Outdated Show resolved Hide resolved
@barpavel
Copy link
Member

barpavel commented Apr 13, 2022

  • mod_auth_openidc

PR description: no mod_auth_openidc change, can remove this comment.
On the other hand please add a sentence, that some deprecated Fedora 30 parts were removed.

@sleviim
Copy link
Member

sleviim commented Apr 14, 2022

maybe worth adding also (optional) ovirt-provider-ovn in case of setting ovirt-ovn on setup

@aesteve-rh aesteve-rh force-pushed the update-readme branch 2 times, most recently from d1a8037 to bf2cb26 Compare April 19, 2022 08:02
@barpavel
Copy link
Member

barpavel commented Apr 19, 2022

  • Install the following system components:

IMHO no need to add httpd to Prerequisites section.
I also checked my old engine VM, no httpd there.
I think httpd was just related to some package Artiom installed on his laptop that is not related to engine.

README.adoc Show resolved Hide resolved
@barpavel barpavel requested a review from sleviim April 19, 2022 11:32
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
Copy link
Member

@barpavel barpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
IMHO ready to be merged :)

README.adoc Outdated Show resolved Hide resolved
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@michalskrivanek michalskrivanek merged commit c471cb0 into oVirt:master Apr 27, 2022
@aesteve-rh aesteve-rh deleted the update-readme branch April 29, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants