-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.adoc #262
Update README.adoc #262
Conversation
no, it is not, mod_auth_openidc is only for RPM installation.
On Tuesday, April 12, 2022, Benny Zlotnik ***@***.***> wrote:
@bennyz commented on this pull request.
________________________________
In README.adoc:
> @@ -494,6 +492,9 @@ During engine setup, a certificate has to be issued
and you will be asked for a
hostname. If you want to upload and download images from administration
portal,
it has to be the name by which your machine is accessible from the
outside.
+NOTE: engine-setup might require mod_auth_openidc for keycloak, if so
you can enable
@arso is this needed for a dev env?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.<
…--
Artur Socha
Senior Software Engineer, RHV
Red Hat
|
0532a9e
to
35a1401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- line 340 - commiting > committing
- in the
Install the following system components:
part, Artiom got a new laptop (RHEL CSB) and had to install also thehttpd
package, maybe worth adding it to the list
35a1401
to
2875508
Compare
PR description: no |
maybe worth adding also |
d1a8037
to
bf2cb26
Compare
IMHO no need to add |
bf2cb26
to
862563f
Compare
862563f
to
ad26837
Compare
ad26837
to
3874522
Compare
3874522
to
8242d24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
IMHO ready to be merged :)
8242d24
to
ca1d349
Compare
ca1d349
to
8645a22
Compare
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
8645a22
to
f1b2898
Compare
Signed-off-by: Albert Esteve aesteve@redhat.com