Update README.adoc #250
Update README.adoc #250
Conversation
aesteve-rh
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
Signed-off-by: Albert Esteve <aesteve@redhat.com>
|
|
||
| - Install additional packages | ||
| + | ||
| $ sudo dnf install -y $(cat automation/check-patch.packages) |
There was a problem hiding this comment.
@nirs I'm not sure changes in lines 160-169 are relevant.
It was an attempt to be similar to PR oVirt/vdsm#121.
There is no automation/check-patch.packages under the project.
Should ioprocess & imageio be here as well?
There was a problem hiding this comment.
ioprocess is not relevant for engine host.
There was a problem hiding this comment.
@ahadas @nirs @bennyz
I think the whole Fedora parts can be removed and some other parts updated.
The instructions are about Fedora 30 (!!!)
There is no automation/check-patch.packages.
The https://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/ doesn't have a Fedora fc folder at all! Nor it has an el folder, but el8 & el9 instead.
I canl update it :)
There was a problem hiding this comment.
@aesteve-rh please remove it in #262
There was a problem hiding this comment.
I just pushed it as you were commenting this, but I can still separate that commit into another PR if you think that's better. Let's move the dicussion to #262
Signed-off-by: Albert Esteve aesteve@redhat.com