-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.adoc #250
Update README.adoc #250
Conversation
Signed-off-by: Albert Esteve <aesteve@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirs For your attention
|
||
- Install additional packages | ||
+ | ||
$ sudo dnf install -y $(cat automation/check-patch.packages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirs I'm not sure changes in lines 160-169 are relevant.
It was an attempt to be similar to PR oVirt/vdsm#121.
There is no automation/check-patch.packages
under the project.
Should ioprocess
& imageio
be here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ioprocess is not relevant for engine host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahadas @nirs @bennyz
I think the whole Fedora parts can be removed and some other parts updated.
The instructions are about Fedora 30 (!!!)
There is no automation/check-patch.packages
.
The https://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/ doesn't have a Fedora fc
folder at all! Nor it has an el
folder, but el8
& el9
instead.
I canl update it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aesteve-rh please remove it in #262
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed it as you were commenting this, but I can still separate that commit into another PR if you think that's better. Let's move the dicussion to #262
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to separate
Signed-off-by: Albert Esteve aesteve@redhat.com