-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #121
Update README.md #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@aesteve-rh please also add:
To the commit message. For this commit, the best way is:
For next commits, modify your .git/hooks/commit-msg to add this automatically:
I guess this is another thing missing in the project documentation. I think this is documented |
f4ff3ab
to
923e850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I updated the branch in the wrong way, and now we need to rebase your local branch and push it again to remove the merge commit.
Signed-off-by: Albert Esteve <aesteve@redhat.com>
In the sample default hooks created by They also say that inserting Signed-off-by in hooks is not a good idea but they don't say why. I think using the hook is OK. |
I never tried the prepare-commit-msg hook. What is the advantage? Using the code added by git init sounds better. The code I added came from the oVirt
It will be best to eliminate this header, the semantics of the header are not clear |
That you see it in the commit message already when you write it.
I agree, I doubt it serves a useful purpose nowadays. In case we need some confirmation from contributors (do we?), it's easier to have it as a part of the PR template. |
Nicer.
PR template is not part of the source, not sure how useful it is. Lets move the discussion about the "signed-of-by" to the devel mailing list. |
After the patch is merged, you can delete the |
Update old repositories list and add Fedora specific packages.