Update README.md

[aesteve-rh]

Update old repositories list and add Fedora specific packages.

[nirs]

Thanks!

[nirs]

@aesteve-rh please also add:

Signed-off-by: Albert Esteve <aesteve@redhat.com>

To the commit message. For this commit, the best way is:

git commit --amend --signoff

For next commits, modify your .git/hooks/commit-msg to add this automatically:

$ cat .git/hooks/commit-msg
#!/bin/sh

# Add signed-off-by lines
SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p')
grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1"

I guess this is another thing missing in the project documentation. I think this is documented
in ovirt.org somewhere, but having it in the project docs is better.

[nirs]

Unfortunately I updated the branch in the wrong way, and now we need to rebase your local branch and push it again to remove the merge commit.

[mz-pdm]

For next commits, modify your .git/hooks/commit-msg to add this automatically:

In the sample default hooks created by git init, at least on my system, it's recommended to use prepare-commit-msg hook (which makes sense) to insert Signed-off-by:. It also includes (somewhat different) code that one can uncomment to insert it.

They also say that inserting Signed-off-by in hooks is not a good idea but they don't say why. I think using the hook is OK.

[nirs]

For next commits, modify your .git/hooks/commit-msg to add this automatically:

In the sample default hooks created by git init, at least on my system, it's recommended to use prepare-commit-msg hook (which makes sense) to insert Signed-off-by:. It also includes (somewhat different) code that one can uncomment to insert it.

I never tried the prepare-commit-msg hook. What is the advantage?

Using the code added by git init sounds better. The code I added came from the oVirt
commit-msg hook linked from ovirt.org.

They also say that inserting Signed-off-by in hooks is not a good idea but they don't say why. I think using the hook is OK.

It will be best to eliminate this header, the semantics of the header are not clear
and I think we just waste time and make it harder for new contributors when we require
it.

[mz-pdm]

I never tried the prepare-commit-msg hook. What is the advantage?

That you see it in the commit message already when you write it.

It will be best to eliminate this header, the semantics of the header are not clear and I think we just waste time and make it harder for new contributors when we require it.

I agree, I doubt it serves a useful purpose nowadays. In case we need some confirmation from contributors (do we?), it's easier to have it as a part of the PR template.

[nirs]

I never tried the prepare-commit-msg hook. What is the advantage?

That you see it in the commit message already when you write it.

Nicer.

It will be best to eliminate this header, the semantics of the header are not clear and I think we just waste time and make it harder for new contributors when we require it.

I agree, I doubt it serves a useful purpose nowadays. In case we need some confirmation from contributors (do we?), it's easier to have it as a part of the PR template.

PR template is not part of the source, not sure how useful it is.

Lets move the discussion about the "signed-of-by" to the devel mailing list.

[barpavel]

After the patch is merged, you can delete the patch_readme branch from both github and locally (with git branch -D patch_readme).