core: adjust volume size when converting to cow/preallocated #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
changed the title
ahadas
reviewed
Apr 18, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ConvertDiskCommand.java
Outdated
Show resolved
Hide resolved
...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ConvertDiskCommand.java
Outdated
Show resolved
Hide resolved
bennyz
commented
Apr 18, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ConvertDiskCommand.java
Outdated
Show resolved
Hide resolved
bennyz
force-pushed
the
use-measured-size
branch
2 times, most recently
from
b885694
to
34c5d77
Compare
ahadas
approved these changes
Apr 18, 2022
bennyz
force-pushed
the
use-measured-size
branch
from
34c5d77
to
32872ad
Compare
emesika
requested changes
Apr 20, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ConvertDiskCommand.java
Outdated
Show resolved
Hide resolved
bennyz
force-pushed
the
use-measured-size
branch
3 times, most recently
from
eebd01d
to
8d083d4
Compare
|
New OST test passed oVirt/ovirt-system-tests#121 (not merged yet) |
When converting to COW/Prellocated from RAW additional size may be required for the qcow header. We already measure required size, however we only use it for the initial size of the volume which is not used when the target is a preallocated volume on block storage. This patch uses required size to increase the target volume if it's larger than the current size of the volume to ensure there is enough space to perform the conversion. Bug-Url: https://bugzilla.redhat.com/2076047 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
use-measured-size
branch
from
8d083d4
to
1a813d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting to COW/Prellocated from RAW additional size may be required for the qcow header. We already measure required size, however we only use it for the initial size of the volume which is not used when the target is a preallocated volume on block storage.
This patch uses required size to increase the target volume if it's larger than the current size of the volume to ensure there is enough space to perform the conversion.
Bug-Url: https://bugzilla.redhat.com/2076047