Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add convert disk test #121

Merged
merged 2 commits into from
May 27, 2022
Merged

add convert disk test #121

merged 2 commits into from
May 27, 2022

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Apr 18, 2022

Convert small raw disk to qcow with incremental backup enabled

@bennyz
Copy link
Member Author

bennyz commented Apr 18, 2022

/ost

@bennyz
Copy link
Member Author

bennyz commented Apr 18, 2022

/ost

@bennyz
Copy link
Member Author

bennyz commented Apr 18, 2022

/ost

@bennyz bennyz force-pushed the convert-disk-test branch 2 times, most recently from 0bed3ca to 58ed668 Compare April 18, 2022 10:13
@bennyz
Copy link
Member Author

bennyz commented Apr 18, 2022

/ost

@bennyz
Copy link
Member Author

bennyz commented Apr 18, 2022

/ost

@bennyz
Copy link
Member Author

bennyz commented Apr 18, 2022

/ost

2 similar comments
@bennyz
Copy link
Member Author

bennyz commented Apr 19, 2022

/ost

@bennyz
Copy link
Member Author

bennyz commented Apr 19, 2022

/ost

@bennyz bennyz requested review from tinez and sleviim April 19, 2022 14:41
@bennyz
Copy link
Member Author

bennyz commented Apr 19, 2022 

17:27:56 basic-suite-master/test-scenarios/test_004_basic_sanity.py::test_convert_disk started at 2022-04-19 16:27:56 PASSED (53s)

tinez
tinez reviewed Apr 20, 2022
View reviewed changes
basic-suite-master/test-scenarios/test_004_basic_sanity.py Outdated
engine = engine_api.system_service()
correlation_id = 'convert_disk'

disks_service = engine.disks_service()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of going through engine_api, then system_service, then disks_service you can simply use disks_service fixture that we already have available in the test signature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, changing to the fixture

basic-suite-master/test-scenarios/test_004_basic_sanity.py Outdated
query={'correlation_id': correlation_id},
)

disk_service = test_utils.get_disk_service(engine, CONVERT_DISK_NAME)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - you can use system_service fixture directly, just add it to test function signature.

BTW we don't actually want to use stuff from test_utils module anymore, but given we have still a lot of references to this particular function I think we'll refactor it on the side.

@tinez
Copy link
Member

tinez commented Apr 20, 2022 

17:27:56 basic-suite-master/test-scenarios/test_004_basic_sanity.py::test_convert_disk started at 2022-04-19 16:27:56 PASSED (53s)

Almost 1 min is a lot actually, what's taking so long in that test?

@bennyz bennyz force-pushed the convert-disk-test branch 2 times, most recently from 77ac77a to 8309d24 Compare April 25, 2022 12:02
@bennyz
Copy link
Member Author

bennyz commented Apr 25, 2022

/ost

@bennyz
Copy link
Member Author

bennyz commented Apr 25, 2022

/ost

@bennyz
Copy link
Member Author

bennyz commented Apr 25, 2022 

17:27:56 basic-suite-master/test-scenarios/test_004_basic_sanity.py::test_convert_disk started at 2022-04-19 16:27:56 PASSED (53s)

Almost 1 min is a lot actually, what's taking so long in that test?

it's a tiny disk, but I guess engine's internal polling for the disk creation and conversion adds up

@bennyz
Copy link
Member Author

bennyz commented Apr 26, 2022

/ost

@bennyz
Copy link
Member Author

bennyz commented Apr 26, 2022

Test passed on last run:

11:33:58 basic-suite-master/test-scenarios/test_004_basic_sanity.py::test_convert_disk started at 2022-04-26 10:33:58 PASSED (50s)

UI test failed:

11:44:49 basic-suite-master/test-scenarios/test_100_basic_ui_sanity.py::test_virtual_machines[chrome] ERROR (2s)Traceback (most recent call last):
11:45:13 File "/home/jenkins/workspace/ds-ost-baremetal_manual/.tox/deps/lib/python3.9/site-packages/pytest/__main__.py", line 5, in <module>
11:45:13 raise SystemExit(pytest.console_main())
11:45:13 File "/home/jenkins/workspace/ds-ost-baremetal_manual/.tox/deps/lib/python3.9/site-packages/_pytest/config/__init__.py", line 185, in console_main
...

@bennyz bennyz mentioned this pull request Apr 26, 2022
Merged
@michalskrivanek
Copy link
Member

/ost

@michalskrivanek
Copy link
Member

/ost basic-suite-master el9stream

1 similar comment
@michalskrivanek
Copy link
Member

/ost basic-suite-master el9stream

bennyz and others added 2 commits May 27, 2022 12:04
@bennyz @michalskrivanek
add convert disk test
bfed28c 
Convert small raw disk to qcow with incremental backup enabled

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@mrkev-gh @michalskrivanek
drop engine_api
36ffc19
@michalskrivanek
Copy link
Member

/ost

@michalskrivanek michalskrivanek merged commit ccc82fe into oVirt:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinez tinez tinez left review comments

@michalskrivanek michalskrivanek michalskrivanek approved these changes

@sleviim sleviim Awaiting requested review from sleviim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bennyz @tinez @michalskrivanek @mrkev-gh