-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Storage Migration - correctly calculate image initial size #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68f6cc3
to
701565e
Compare
f6cf024
to
34f99c6
Compare
72d395b
to
ca5ba57
Compare
ca5ba57
to
2a990d7
Compare
nirs
suggested changes
May 16, 2022
...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
Outdated
Show resolved
Hide resolved
...odules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
Outdated
Show resolved
Hide resolved
nirs
reviewed
May 17, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
Outdated
Show resolved
Hide resolved
2a990d7
to
fb58a3d
Compare
barpavel
commented
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial comments handling, continuing with the others.
...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
Outdated
Show resolved
Hide resolved
ahadas
reviewed
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review
...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
Show resolved
Hide resolved
...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
Outdated
Show resolved
Hide resolved
...odules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
Outdated
Show resolved
Hide resolved
barpavel
commented
May 18, 2022
...d/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Outdated
Show resolved
Hide resolved
bennyz
reviewed
Jun 13, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
Outdated
Show resolved
Hide resolved
bennyz
reviewed
Jun 13, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
Outdated
Show resolved
Hide resolved
090979d
to
ddbfc6d
Compare
12836af
to
ee6df3d
Compare
Added a detailed flow table that describes the "CloneImageGroupVolumesStructureCommand#determineImageInitialSize()" desired behavior (current & new). Lines 3 (file-->block) & 4 (block-->block) are to be implemented in the follow-up commits. Signed-off-by: Pavel Bar <pbar@redhat.com> Bug-Url: https://bugzilla.redhat.com/1958032
1. Added a new "needExtend" parameter to "VmReplicateDiskStartVDS". 2. Some minor code reformatting and typos fixes. 3. Fixing warnings related to the raw type of the "Map" parameters in "diskReplicateStart()" & "diskReplicateFinish" method declarations. Thus the "SuppressWarnings" can be removed. 4. Added the missing "diskType" data member to "VmReplicateDiskParameters#appendAttributes()", together with the new parameter. Signed-off-by: Pavel Bar <pbar@redhat.com> Bug-Url: https://bugzilla.redhat.com/1958032
1. Block --> Block Adding initial disk size calculation for Live Storage Migration for disks that reside on Block Storage Domain (for cluster version is 4.7 or above) Instead of adding new data members in different parameter classes, I used the already existing mechanism for that - "DiskImagesMap" that is passed through several commands classes till where it's actually needed & used. 2. File --> Block Signed-off-by: Pavel Bar <pbar@redhat.com> Bug-Url: https://bugzilla.redhat.com/1958032
ee6df3d
to
36d44e9
Compare
/ost |
ahadas
approved these changes
Jun 15, 2022
bennyz
approved these changes
Jun 15, 2022
barpavel
added a commit
to barpavel/ovirt-engine
that referenced
this pull request
Jul 10, 2022
Small code improvements in a separate PR in order to keep oVirt#305 focused on important changes. 1) Fixed typos variable & method names. 2) Improved variable names. 3) Fixed a potential NPE. 4) Eliminated code warnings 5) Simplified code, improved comments. 6) Handled too long lines or redundant breaking to a newline. 7) Minor code reformatting to improve readability and create a more consistent code style. Signed-off-by: Pavel Bar <pbar@redhat.com>
barpavel
added a commit
to barpavel/ovirt-engine
that referenced
this pull request
Jul 10, 2022
Small code improvements in a separate PR in order to keep oVirt#305 focused on important changes. 1) Fixed typos variable & method names. 2) Improved variable names. 3) Fixed a potential NPE. 4) Eliminated code warnings 5) Simplified code, improved comments. 6) Handled too long lines or redundant breaking to a newline. 7) Minor code reformatting to improve readability and create a more consistent code style. Signed-off-by: Pavel Bar <pbar@redhat.com>
barpavel
added a commit
to barpavel/ovirt-engine
that referenced
this pull request
Jul 10, 2022
Small code improvements in a separate PR in order to keep oVirt#305 focused on important changes. 1) Fixed typos variable & method names. 2) Improved variable names. 3) Fixed a potential NPE. 4) Eliminated code warnings 5) Simplified code, improved comments. 6) Handled too long lines or redundant breaking to a newline. 7) Minor code reformatting to improve readability and create a more consistent code style. Signed-off-by: Pavel Bar <pbar@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding image initial size calculation for Live Storage Migration flows for disks
that reside on Block Storage Domain.
Relevant for cluster version 4.7 or above.
Bug-Url: https://bugzilla.redhat.com/1958032