Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Storage Migration - correctly calculate image initial size #305

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Live Storage Migration - correctly calculate image initial size #305

merged 3 commits into from
Jun 15, 2022

Conversation

barpavel
Copy link
Member

@barpavel barpavel commented Apr 25, 2022 •
edited
Loading

Adding image initial size calculation for Live Storage Migration flows for disks
that reside on Block Storage Domain.
Relevant for cluster version 4.7 or above.

Bug-Url: https://bugzilla.redhat.com/1958032

@barpavel barpavel marked this pull request as draft April 25, 2022 11:23
@ahadas ahadas added the storage label Apr 28, 2022
@barpavel barpavel marked this pull request as ready for review May 2, 2022 10:46
@barpavel barpavel force-pushed the live_storage_migration branch 4 times, most recently from f6cf024 to 34f99c6 Compare May 2, 2022 13:54
@sandrobonazzola sandrobonazzola added this to the ovirt-4.5.1 milestone May 6, 2022
@barpavel barpavel force-pushed the live_storage_migration branch 2 times, most recently from 72d395b to ca5ba57 Compare May 16, 2022 10:20
@barpavel barpavel requested a review from nirs May 16, 2022 10:51
@barpavel barpavel requested review from mkemel and sleviim May 16, 2022 10:57
nirs
nirs suggested changes May 16, 2022
View reviewed changes
...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java Outdated Show resolved Hide resolved
packaging/etc/engine-config/engine-config.properties Outdated Show resolved Hide resolved
packaging/etc/engine-config/engine-config.properties Outdated Show resolved Hide resolved
packaging/etc/engine-config/engine-config.properties Outdated Show resolved Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java Outdated Show resolved Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java Outdated Show resolved Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java Outdated Show resolved Hide resolved
...odules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java Outdated Show resolved Hide resolved
barpavel
barpavel commented May 18, 2022
View reviewed changes
Copy link
Member Author

@barpavel barpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial comments handling, continuing with the others.

...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java Outdated Show resolved Hide resolved
packaging/etc/engine-config/engine-config.properties Outdated Show resolved Hide resolved
packaging/etc/engine-config/engine-config.properties Outdated Show resolved Hide resolved
ahadas
ahadas reviewed May 18, 2022
View reviewed changes
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review

...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java Show resolved Hide resolved
...ava/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java Outdated Show resolved Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java Outdated Show resolved Hide resolved
...odules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java Outdated Show resolved Hide resolved
@barpavel barpavel force-pushed the live_storage_migration branch 3 times, most recently from 090979d to ddbfc6d Compare June 15, 2022 13:56
@barpavel barpavel marked this pull request as ready for review June 15, 2022 13:58
@barpavel barpavel marked this pull request as draft June 15, 2022 14:02
@barpavel barpavel force-pushed the live_storage_migration branch 5 times, most recently from 12836af to ee6df3d Compare June 15, 2022 14:53
@barpavel
core: added detailed description to "determineImageInitialSize()"
f5da1d3 
Added a detailed flow table that describes the
"CloneImageGroupVolumesStructureCommand#determineImageInitialSize()"
desired behavior (current & new).
Lines 3 (file-->block) & 4 (block-->block) are to be implemented in
the follow-up commits.

Signed-off-by: Pavel Bar <pbar@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1958032
@barpavel
core: add a "needExtend" parameter to "VmReplicateDiskStartVDS"
3c10763 
1. Added a new "needExtend" parameter to "VmReplicateDiskStartVDS".
2. Some minor code reformatting and typos fixes.
3. Fixing warnings related to the raw type of the "Map" parameters
in "diskReplicateStart()" & "diskReplicateFinish" method declarations.
Thus the "SuppressWarnings" can be removed.
4. Added the missing "diskType" data member to
"VmReplicateDiskParameters#appendAttributes()", together with the new parameter.

Signed-off-by: Pavel Bar <pbar@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1958032
@barpavel
core: implementation of the last 2 LSM flows
36d44e9 
1. Block --> Block
Adding initial disk size calculation for Live Storage Migration for disks
that reside on Block Storage Domain (for cluster version is 4.7 or above)
Instead of adding new data members in different parameter classes, I used
the already existing mechanism for that - "DiskImagesMap" that is passed
through several commands classes till where it's actually needed & used.
2. File --> Block

Signed-off-by: Pavel Bar <pbar@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1958032
@barpavel barpavel marked this pull request as ready for review June 15, 2022 14:57
@barpavel barpavel changed the title Live Storage Migration - correctly calculate image size Live Storage Migration - correctly calculate image initial size Jun 15, 2022
@barpavel
Copy link
Member Author

/ost

@ahadas ahadas requested a review from bennyz June 15, 2022 17:06
@ahadas ahadas merged commit fb507d9 into oVirt:master Jun 15, 2022
@barpavel barpavel deleted the live_storage_migration branch June 23, 2022 08:38
@barpavel barpavel mentioned this pull request Jul 10, 2022
Merged
barpavel added a commit to barpavel/ovirt-engine that referenced this pull request Jul 10, 2022
@barpavel
core: "LiveMigrateDiskCommand" small code improvements
f9d18f1 
Small code improvements in a separate PR in order to keep
oVirt#305 focused on important changes.

1) Fixed typos variable & method names.
2) Improved variable names.
3) Fixed a potential NPE.
4) Eliminated code warnings
5) Simplified code, improved comments.
6) Handled too long lines or redundant breaking to a newline.
7) Minor code reformatting to improve readability and
create a more consistent code style.

Signed-off-by: Pavel Bar <pbar@redhat.com>
barpavel added a commit to barpavel/ovirt-engine that referenced this pull request Jul 10, 2022
@barpavel
core: "LiveMigrateDiskCommand" small code improvements
51e9914 
Small code improvements in a separate PR in order to keep
oVirt#305 focused on important changes.

1) Fixed typos variable & method names.
2) Improved variable names.
3) Fixed a potential NPE.
4) Eliminated code warnings
5) Simplified code, improved comments.
6) Handled too long lines or redundant breaking to a newline.
7) Minor code reformatting to improve readability and
create a more consistent code style.

Signed-off-by: Pavel Bar <pbar@redhat.com>
barpavel added a commit to barpavel/ovirt-engine that referenced this pull request Jul 10, 2022
@barpavel
core: "LiveMigrateDiskCommand" small code improvements
fd99ac2 
Small code improvements in a separate PR in order to keep
oVirt#305 focused on important changes.

1) Fixed typos variable & method names.
2) Improved variable names.
3) Fixed a potential NPE.
4) Eliminated code warnings
5) Simplified code, improved comments.
6) Handled too long lines or redundant breaking to a newline.
7) Minor code reformatting to improve readability and
create a more consistent code style.

Signed-off-by: Pavel Bar <pbar@redhat.com>
@barpavel barpavel mentioned this pull request Aug 3, 2022
Merged
@barpavel barpavel mentioned this pull request Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirs nirs nirs requested changes

@bennyz bennyz bennyz approved these changes

@ahadas ahadas ahadas approved these changes

@emesika emesika Awaiting requested review from emesika emesika is a code owner

@mwperina mwperina Awaiting requested review from mwperina mwperina is a code owner

@michalskrivanek michalskrivanek Awaiting requested review from michalskrivanek michalskrivanek is a code owner

@oliel oliel Awaiting requested review from oliel

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@didib didib Awaiting requested review from didib didib is a code owner

@mkemel mkemel Awaiting requested review from mkemel

@sleviim sleviim Awaiting requested review from sleviim

Assignees

@barpavel barpavel

Labels
storage
Projects
None yet
Milestone
ovirt-4.5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@barpavel @ahadas @nirs @bennyz @sandrobonazzola