core: "LiveMigrateDiskCommand" small code improvements #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barpavel
force-pushed
the
lsm_small_improvements
branch
4 times, most recently
from
fd99ac2
to
75557b9
Compare
barpavel
commented
Jul 10, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
Outdated
Show resolved
Hide resolved
|
/ost |
barpavel
force-pushed
the
lsm_small_improvements
branch
3 times, most recently
from
805ea3e
to
c18e706
Compare
|
/ost |
Fixed typos in variables, method names & comments. Signed-off-by: Pavel Bar <pbar@redhat.com>
Fixed a potential NPE and eliminated code warning that was related to it. Signed-off-by: Pavel Bar <pbar@redhat.com>
1) Remove "is qualified for live merge" check:
Block commit is used since 4.2, see [1], [2].
So "getVm().getStatus().isQualifiedForLiveSnapshotMerge()"
check is not needed anymore.
2) Remove redundant enum check:
a) Simplifying the "isRemoveAutoGeneratedSnapshotRequired()" method:
There is no need to test the 2nd part in the condition that looks like:
stage == enumA && stage != enumB
b) After the above simplification, the method can be inlined to receive
an even more simple code.
[1] https://bugzilla.redhat.com/1246114
[2] https://bugzilla.redhat.com/1369942
Signed-off-by: Pavel Bar <pbar@redhat.com>
barpavel
force-pushed
the
lsm_small_improvements
branch
from
c18e706
to
60830c0
Compare
|
/ost |
bennyz
approved these changes
Jul 14, 2022
ahadas
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small code improvements in a separate PR in order to keep #305 focused on important changes.
getVm().getStatus().isQualifiedForLiveSnapshotMerge()check.Signed-off-by: Pavel Bar pbar@redhat.com