Block on execution of ImportVmFromConfiguration #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
force-pushed
the
sync_import_from_conf
branch
from
2edacbc
to
2efe8ab
Compare
bennyz
approved these changes
Apr 28, 2022
ahadas
force-pushed
the
sync_import_from_conf
branch
from
2efe8ab
to
d5bdb41
Compare
ahadas
requested review from
emesika,
michalskrivanek,
sgratch and
didib
as code owners
bennyz
reviewed
Apr 29, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Outdated
Show resolved
Hide resolved
ahadas
force-pushed
the
sync_import_from_conf
branch
from
d5bdb41
to
436cb0d
Compare
oliel
approved these changes
May 2, 2022
|
I understand this is a unique case, and that it always makes sense to block, and that existing applications suffer from this. So it's fine by me, but please add a comment in ovirt-engien-api-model for this flow, that it is always performed with async=false and user has no way to select otherwise |
|
@nyoxi I know it renders |
nyoxi
approved these changes
May 2, 2022
we don't normally to this but in case of ImportVmFromConfiguration it makes some sense to invoke it as a blocking (sync) operation since it doesn't involve disk operation so if may only have async operation related to vm leases which are relatively quick. The main reason to do this is that some backup applications relied on getting Created response and can't cope with Accepted but it also makes to do that because it is often the case that clients try to start the VM right after the execution of ImportVmFromConfiguration is completed. Bug-Url: https://bugzilla.redhat.com/2074112 Signed-off-by: Arik Hadas <ahadas@redhat.com>
Set entity-info in the parameters of AddVmLease to avoid the pre-polling period in case a VM with a lease is imported from configuration. Bug-Url: https://bugzilla.redhat.com/2074112 Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
force-pushed
the
sync_import_from_conf
branch
from
436cb0d
to
85dade0
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't normally to this but in case of ImportVmFromConfiguration it makes
some sense to invoke it as a blocking (sync) operation since it doesn't involve
disk operation so if may only have async operation related to vm leases which are
relatively quick. The main reason to do this is that some backup applications
relied on getting Created response and can't cope with Accepted but it also makes
to do that because it is often the case that clients try to start the VM right
after the execution of ImportVmFromConfiguration is completed.
Bug-Url: https://bugzilla.redhat.com/2074112
Signed-off-by: Arik Hadas ahadas@redhat.com