-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block on execution of ImportVmFromConfiguration #318
Conversation
2edacbc
to
2efe8ab
Compare
2efe8ab
to
d5bdb41
Compare
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Outdated
Show resolved
Hide resolved
d5bdb41
to
436cb0d
Compare
I understand this is a unique case, and that it always makes sense to block, and that existing applications suffer from this. So it's fine by me, but please add a comment in ovirt-engien-api-model for this flow, that it is always performed with async=false and user has no way to select otherwise |
@nyoxi I know it renders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The change in virt-v2v is still useful for older RHV environments.
we don't normally to this but in case of ImportVmFromConfiguration it makes some sense to invoke it as a blocking (sync) operation since it doesn't involve disk operation so if may only have async operation related to vm leases which are relatively quick. The main reason to do this is that some backup applications relied on getting Created response and can't cope with Accepted but it also makes to do that because it is often the case that clients try to start the VM right after the execution of ImportVmFromConfiguration is completed. Bug-Url: https://bugzilla.redhat.com/2074112 Signed-off-by: Arik Hadas <ahadas@redhat.com>
Set entity-info in the parameters of AddVmLease to avoid the pre-polling period in case a VM with a lease is imported from configuration. Bug-Url: https://bugzilla.redhat.com/2074112 Signed-off-by: Arik Hadas <ahadas@redhat.com>
436cb0d
to
85dade0
Compare
/ost |
we don't normally to this but in case of ImportVmFromConfiguration it makes
some sense to invoke it as a blocking (sync) operation since it doesn't involve
disk operation so if may only have async operation related to vm leases which are
relatively quick. The main reason to do this is that some backup applications
relied on getting Created response and can't cope with Accepted but it also makes
to do that because it is often the case that clients try to start the VM right
after the execution of ImportVmFromConfiguration is completed.
Bug-Url: https://bugzilla.redhat.com/2074112
Signed-off-by: Arik Hadas ahadas@redhat.com