Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block on execution of ImportVmFromConfiguration #318

Merged
merged 2 commits into from
May 2, 2022
Merged

Block on execution of ImportVmFromConfiguration #318

merged 2 commits into from
May 2, 2022

Commits on May 2, 2022

  1. api: block on execution of ImportVmFromConfiguration 

    we don't normally to this but in case of ImportVmFromConfiguration it makes
some sense to invoke it as a blocking (sync) operation since it doesn't involve
disk operation so if may only have async operation related to vm leases which are
relatively quick. The main reason to do this is that some backup applications
relied on getting Created response and can't cope with Accepted but it also makes
to do that because it is often the case that clients try to start the VM right
after the execution of ImportVmFromConfiguration is completed.

Bug-Url: https://bugzilla.redhat.com/2074112
Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed May 2, 2022
    Configuration menu
    Copy the full SHA
    00c6d69 View commit details
    Browse the repository at this point in the history

  2. core: avoid pre-polling in import-vm-from-configuration 

    Set entity-info in the parameters of AddVmLease to avoid the pre-polling
period in case a VM with a lease is imported from configuration.

Bug-Url: https://bugzilla.redhat.com/2074112
Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed May 2, 2022
    Configuration menu
    Copy the full SHA
    85dade0 View commit details
    Browse the repository at this point in the history