-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add new configuration for volume chunk size #381
core: add new configuration for volume chunk size #381
Conversation
Looks like (while adding Storage team members for the code review) I unintentionally removed many people that were added automatically, should I add them back? |
/ost |
2b66690
to
1fe6d32
Compare
/ost |
tip for next time - better to use a url from an existing tag like (the file on master may change): https://github.com/oVirt/vdsm/blob/v4.50.1/lib/vdsm/common/config.py.in#L325 |
Thanks, didn't know that :) |
Adding new configuration for volume chunk size. This duplicates VDSM "irs:volume_utilization_chunk_mb" configuration. https://github.com/oVirt/vdsm/blob/v4.50.1/lib/vdsm/common/config.py.in#L325 Duplicating the configration is bad. But until the configuration is totally moved to engine, we have no other way to use the right size for creating new volumes. Signed-off-by: Pavel Bar <pbar@redhat.com> Bug-Url: https://bugzilla.redhat.com/1958032
1fe6d32
to
4214782
Compare
Done, both in PR and commit descriptions. |
Adding new configuration for volume chunk size.
This duplicates VDSM
irs:volume_utilization_chunk_mb
configuration.https://github.com/oVirt/vdsm/blob/v4.50.1/lib/vdsm/common/config.py.in#L325
Duplicating the configuration is bad.
But until the configuration is totally moved to engine, we have no other way to use the right size for creating new volumes.
This commit was part of #305, but in order to enable faster merging and using this new parameter extracting it out.
Bug-Url: https://bugzilla.redhat.com/1958032