core: add new configuration for volume chunk size #381
Conversation
barpavel
requested review from
emesika,
mwperina,
ahadas,
bennyz,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
Looks like (while adding Storage team members for the code review) I unintentionally removed many people that were added automatically, should I add them back? |
|
/ost |
barpavel
force-pushed
the
add_volume_chunk_size_configuration
branch
from
2b66690
to
1fe6d32
Compare
|
/ost |
tip for next time - better to use a url from an existing tag like (the file on master may change): https://github.com/oVirt/vdsm/blob/v4.50.1/lib/vdsm/common/config.py.in#L325 |
Thanks, didn't know that :) |
Adding new configuration for volume chunk size. This duplicates VDSM "irs:volume_utilization_chunk_mb" configuration. https://github.com/oVirt/vdsm/blob/v4.50.1/lib/vdsm/common/config.py.in#L325 Duplicating the configration is bad. But until the configuration is totally moved to engine, we have no other way to use the right size for creating new volumes. Signed-off-by: Pavel Bar <pbar@redhat.com> Bug-Url: https://bugzilla.redhat.com/1958032
barpavel
force-pushed
the
add_volume_chunk_size_configuration
branch
from
1fe6d32
to
4214782
Compare
Done, both in PR and commit descriptions. |
Adding new configuration for volume chunk size.
This duplicates VDSM
irs:volume_utilization_chunk_mbconfiguration.https://github.com/oVirt/vdsm/blob/v4.50.1/lib/vdsm/common/config.py.in#L325
Duplicating the configuration is bad.
But until the configuration is totally moved to engine, we have no other way to use the right size for creating new volumes.
This commit was part of #305, but in order to enable faster merging and using this new parameter extracting it out.
Bug-Url: https://bugzilla.redhat.com/1958032