core: copy disk will set the correct allocation policy for the new copied disk #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomDivak
requested review from
bennyz,
ahadas,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
bennyz
reviewed
May 26, 2022
...src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java
Outdated
Show resolved
Hide resolved
sleviim
reviewed
May 26, 2022
...src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java
Outdated
Show resolved
Hide resolved
barpavel
reviewed
May 26, 2022
...rc/main/java/org/ovirt/engine/core/common/action/CreateVolumeContainerCommandParameters.java
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2072423
branch
2 times, most recently
from
1dd9286
to
56e15ef
Compare
|
/ost |
sleviim
suggested changes
May 30, 2022
...src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/ovirt/engine/core/common/action/CreateVolumeContainerCommandParameters.java
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2072423
branch
2 times, most recently
from
185984b
to
5acd4c2
Compare
barpavel
approved these changes
May 30, 2022
...src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java
Outdated
Show resolved
Hide resolved
|
/ost |
bennyz
reviewed
Jun 1, 2022
...src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java
Outdated
Show resolved
Hide resolved
|
/ost |
|
/ost |
sleviim
reviewed
Jun 1, 2022
ArtiomDivak
force-pushed
the
bug-2072423
branch
2 times, most recently
from
2669afa
to
94b2ab6
Compare
…pied disk while coping disk that has incremental backup flag up and set to be preallocated the new copied disk will change the allocation policy to thin provition. now it will change allocation policy to be the same as it was set on the original disk Bug-Url: https://bugzilla.redhat.com/2072423 Signed-off-by: Artiom Divak <adivak@redhat.com>
|
/ost |
1 similar comment
|
/ost |
sleviim
approved these changes
Jun 2, 2022
sleviim
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while coping disk that has incremental backup flag up and set to be preallocated
the new copied disk will change the allocation policy to thin provision.
now it will change the allocation policy to be the same as it was set on the original disk
Bug-Url: https://bugzilla.redhat.com/2072423
Signed-off-by: Artiom Divak adivak@redhat.com