packaging: setup: Add KeycloakEnv.SUPPORTED #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didib
force-pushed
the
add-keycloak-supported
branch
from
886e423
to
c20976c
Compare
arso
approved these changes
Jun 7, 2022
ovirt-engine.spec.in
Outdated
| @@ -1020,6 +1020,14 @@ OVESETUP_CONFIG/jbossHome=str:/opt/rh/eap7/root/usr/share/wildfly | |||
| OVESETUP_CONFIG/pkiRenewalDocUrl=str:https://access.redhat.com/solutions/1572983 | |||
| __EOF__ | |||
|
|
|||
| # Disable automatic keycloak integration in RHV. | |||
| # Manual integration is possible and documented at ??? | |||
| # TODO: Provide a link. I found this, but think there are probably better ones: | |||
There was a problem hiding this comment.
Please open an issue to track this
There was a problem hiding this comment.
Fixed the link and removed the TODO comment
Allow setup code to decide/know if Keycloak integration is supported. Set as unsupported for RHV. Change-Id: I5ec0fee15cc761238989afaec55db9a5aa831778 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
force-pushed
the
add-keycloak-supported
branch
from
c20976c
to
6fa3339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setup code to decide/know if Keycloak integration is
supported. In RHV it's not.
Change-Id: I5ec0fee15cc761238989afaec55db9a5aa831778
Signed-off-by: Yedidyah Bar David didi@redhat.com