-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: setup: Add KeycloakEnv.SUPPORTED #417
Conversation
886e423
to
c20976c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified my usual testing scenario + bakcup & restore. All good.
ovirt-engine.spec.in
Outdated
@@ -1020,6 +1020,14 @@ OVESETUP_CONFIG/jbossHome=str:/opt/rh/eap7/root/usr/share/wildfly | |||
OVESETUP_CONFIG/pkiRenewalDocUrl=str:https://access.redhat.com/solutions/1572983 | |||
__EOF__ | |||
|
|||
# Disable automatic keycloak integration in RHV. | |||
# Manual integration is possible and documented at ??? | |||
# TODO: Provide a link. I found this, but think there are probably better ones: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open an issue to track this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the link and removed the TODO comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Allow setup code to decide/know if Keycloak integration is supported. Set as unsupported for RHV. Change-Id: I5ec0fee15cc761238989afaec55db9a5aa831778 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
c20976c
to
6fa3339
Compare
Allow setup code to decide/know if Keycloak integration is
supported. In RHV it's not.
Change-Id: I5ec0fee15cc761238989afaec55db9a5aa831778
Signed-off-by: Yedidyah Bar David didi@redhat.com