core: produce successful event if backup finished successfully #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
backup-audit-log-success
branch
from
e653de9
to
43b2b39
Compare
|
that's a good alternative, let's give a chance for wait-lock and use this approach as a fallback |
As discussed, this is relevant regardless for cases where snapshot removal fails for reasons other than validation |
|
/ost |
ahadas
reviewed
Jun 21, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Outdated
Show resolved
Hide resolved
Even if we were unable to remove the auto-generated snapshot, the backup will be considered successful. This patch produces the right audit log entry to indicate the backup did not fail. Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
backup-audit-log-success
branch
from
43b2b39
to
c35905d
Compare
ahadas
approved these changes
Jun 21, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if we were unable to remove the auto-generated snapshot, the backup will be considered successful. This patch produces the right audit log entry to indicate the backup did not fail.