MBS not supporting MoveOrCopy command #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArtiomDivak is there a relevant bug for this? |
ahadas
reviewed
Jul 6, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2077666
branch
3 times, most recently
from
73ccfd5
to
d7d46bc
Compare
ArtiomDivak
changed the title
ahadas
approved these changes
Jul 14, 2022
|
Copy is actually supported, what's missing is copying to an MBS domain from a local DC, so the validation should simply check if the source/target is on a local DC and block the operation in that case |
ahadas
reviewed
Jul 17, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
bennyz
reviewed
Jul 18, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2077666
branch
3 times, most recently
from
4f87f38
to
20aa0f0
Compare
ahadas
reviewed
Jul 20, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2077666
branch
2 times, most recently
from
82e2153
to
803da05
Compare
ArtiomDivak
requested review from
sgratch,
ljelinkova,
emesika,
mwperina,
michalskrivanek and
oliel
as code owners
ljelinkova
suggested changes
Jul 20, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
ljelinkova
reviewed
Jul 21, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
ahadas
reviewed
Jul 24, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
Outdated
Show resolved
Hide resolved
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2077666
branch
4 times, most recently
from
56d593e
to
c7f69a6
Compare
ahadas
changed the title
ahadas
reviewed
Aug 1, 2022
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bug-2077666
branch
from
c7f69a6
to
094bb91
Compare
ArtiomDivak
force-pushed
the
bug-2077666
branch
from
094bb91
to
fbcff99
Compare
|
/ost |
If User will try to move or copy a disk int to MBS (this operation is not supported yet) he will get the error 'Cannot copy Virtual Disk. Managed Block Storage is not supported this operation' Bug-Url: https://bugzilla.redhat.com/2077666 Signed-off-by: Artiom Divak <adivak@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If User will try to move or copy a disk into MBS (this operation is not supported yet)
he will get the error 'Cannot copy Virtual Disk. Managed Block Storage is not supported this operation'
Bug-Url: https://bugzilla.redhat.com/2077666
Signed-off-by: Artiom Divak adivak@redhat.com