core: update actual size after conversion #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ost |
ahadas
reviewed
Jun 27, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ConvertDiskCommand.java
Outdated
Show resolved
Hide resolved
bennyz
force-pushed
the
update-actual-size
branch
from
ccf7707
to
e4f92ae
Compare
ahadas
approved these changes
Jun 28, 2022
|
/ost |
The actual size of a volume is reduced when converting the disk from COW/preallocated to COW/thin on a block storage domain is not updated, making it seem like disk consumes more than it actually does. This patch updates the actual size after conversion. Bug-Url: https://bugzilla.redhat.com/2086561 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
ahadas
force-pushed
the
update-actual-size
branch
from
e4f92ae
to
2a8faaa
Compare
ahadas
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual size of a volume is reduced when converting the disk from COW/preallocated to COW/thin on a block storage domain is not updated, making it seem like disk consumes more than it actually does.
This patch updates the actual size after conversion.
Bug-Url: https://bugzilla.redhat.com/2086561