Set initial event number for async ansible commands #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
/ost |
|
/ost |
mnecas
approved these changes
Jun 27, 2022
mwperina
requested changes
Jun 27, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AnsibleCommandBase.java
Outdated
Show resolved
Hide resolved
If the ansible playbook execution happened faster than the engine, we may get a successful status and the correct number of events. In that case we may skip the event processing in the ansible callback. Which may lead us to wrong data returned to the command itself. Change-Id: I432938a7fc241701eb260c1fbc460d1de7149092 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
mnecas
added a commit
to mnecas/ovirt-engine
that referenced
this pull request
Jun 28, 2022
mnecas
added a commit
to mnecas/ovirt-engine
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ansible playbook execution happened faster than the engine, we
may get a successful status and the correct number of events. In that
case we may skip the event processing in the ansible callback. Which may
lead us to wrong data returned to the command itself.
Change-Id: I432938a7fc241701eb260c1fbc460d1de7149092
Signed-off-by: Liran Rotenberg lrotenbe@redhat.com