Revert "Ansible-runner: Fix getting status of playbook" and Revert "Set initial event number for async ansible commands" #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnecas
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
mnecas
force-pushed
the
revert-468-fix_ansible_polling_status
branch
from
fa7fbde
to
49b9fbe
Compare
mnecas
force-pushed
the
revert-468-fix_ansible_polling_status
branch
from
49b9fbe
to
3c101d7
Compare
mnecas
changed the title
|
/ost |
|
it doesn't make sense to blindly change things or revert, added more debugging now in #502 and once we see the issue again it should give us more insight into what's going on. Then we can see what fix or revert is needed |
I agree with Michal's comment above but I meant to elaborate within the commit message or/and the description of the PR so we'll be able to tell later on, if needed, why it was reverted |
|
/ost |
|
#546 fixed it good enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #468 and #499