Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lastEventId tracking #546

Merged
merged 4 commits into from
Jul 22, 2022
Merged

fix lastEventId tracking #546

merged 4 commits into from
Jul 22, 2022

Conversation

michalskrivanek
Copy link
Member

  • core: remove redundant set
  • core: fix lastEventId tracking

@michalskrivanek michalskrivanek mentioned this pull request Jul 21, 2022
Closed
@michalskrivanek
core: fix lastEventId tracking
39908a8 
due to singleton usage we may be reading wrong lastEventId, but it is
not really needed so let's siplify the logic and use the existing
AnsibleReturnValue for keeping track of it.
@michalskrivanek
Copy link
Member Author

/ost

1 similar comment
@michalskrivanek
Copy link
Member Author

/ost

mnecas
mnecas approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michalskrivanek
Copy link
Member Author

/ost

@michalskrivanek
Copy link
Member Author

/ost

@mnecas mnecas mentioned this pull request Jul 22, 2022
Merged
@michalskrivanek
core: use PlaybookStatus to determine playbook has ended
407d068 
Instead of parsing the current event we can reuse the same logic as used
for async playbooks, check the "status" artifact to see if ansible is
still running or not, and check if all events have been processed
@michalskrivanek
core: add ansible-runner comments
49d6f15 
we rely on this exact behavior of ansible-runner, let's document it
@michalskrivanek michalskrivanek merged commit 995f4a0 into master Jul 22, 2022
@michalskrivanek michalskrivanek deleted the ar-fix branch July 22, 2022 12:49
@michalskrivanek michalskrivanek mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnecas mnecas mnecas approved these changes

@ahadas ahadas Awaiting requested review from ahadas ahadas is a code owner

@bennyz bennyz Awaiting requested review from bennyz bennyz is a code owner

@emesika emesika Awaiting requested review from emesika emesika is a code owner

@mwperina mwperina Awaiting requested review from mwperina mwperina is a code owner

@oliel oliel Awaiting requested review from oliel

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@didib didib Awaiting requested review from didib didib is a code owner

@ljelinkova ljelinkova Awaiting requested review from ljelinkova

@dangel101 dangel101 Awaiting requested review from dangel101

@liranr23 liranr23 Awaiting requested review from liranr23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalskrivanek @mnecas