AnsibleRunner: reset lastEvent

[mnecas]

When the runner gets LastEventId: 0 and totalEvents: 0. The client does not find any new events so we have null event and break the while(true).

ovirt-engine/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerClient.java

Lines 124 to 128 in 9336b4f

	String jobEvents = getJobEventsDir(playUuid);
	while(true){
	String event = getNextEvent(playUuid, lastEventId);
	if (event == null) {
	break;

The AnsibleCallback is using a singleton of the AnsibleRunnerClient because of this we get the previous run lastEvent which is not empty so we call getLastEventId`.

ovirt-engine/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerClient.java

Line 194 in 9336b4f

return lastEvent.isEmpty() ? lastEventId : getLastEventId();

In the getLastEventId we get the return of the prefix index of the file which is the lastEventId and because it's from the previous run it overrides the current id.

ovirt-engine/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerClient.java

Lines 111 to 113 in 9336b4f

	public int getLastEventId() {
	return Integer.valueOf(lastEvent.split("-")[0]);
	}

[michalskrivanek]

but this is the onl break out of the infinite loop. So the return value condition is ineffective AFAICT and can just return lastEventId always?

[michalskrivanek]

It might be best - or even required, looking at playHasEnded - to eliminate lastEvent completely

[mnecas]

Could be... this is more question for @dangel101... in what situation we need lastEvent?

[michalskrivanek]

Use the grep, Luke!

Could be... this is more question for @dangel101... in what situation we need lastEvent?

http://bezdelnique.ru/wp-content/uploads/2009/08/use_source_luke-500x388.png

[mnecas]

Use the grep, Luke!

Could be... this is more question for @dangel101... in what situation we need lastEvent?

http://bezdelnique.ru/wp-content/uploads/2009/08/use_source_luke-500x388.png

what I understand from code is it seems like we don't need it at all and we could just use lastEventId

[mnecas]

/ost

[mnecas]

/ost

[michalskrivanek]

I've meant something more like #546

[michalskrivanek]

replaced by #546 and #547

[dangel101]

Could be... this is more question for @dangel101... in what situation we need lastEvent?

While we don't know how many events we expect, we do know that in any case the last event contains the run's stats. So that helps to determine if a run has actually ended