Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssh port to ansible command config vars #550

Conversation

dangel101
Copy link
Member

This enables executing playbooks with hosts that are configured with a non-standard SSH port

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2104939

This enables executing playbooks with hosts that are configured with a non-standard SSH port

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2104939
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina
Copy link
Member

/ost

Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we'll need this in all places that we execute playbooks, also in places like MaintenanceVdsCommand#runAnsibleMigrationCerts and RemoveVdsCommand#runAnsibleRemovePlaybook, no? if that's the case, how about changing AnsibleCommandConfig#hosts to 'host' (I don't see a place we provide more than a single host) and then configure the port "behind the scenes"?

@dangel101
Copy link
Member Author

I thought we'll need this in all places that we execute playbooks, also in places like MaintenanceVdsCommand#runAnsibleMigrationCerts and RemoveVdsCommand#runAnsibleRemovePlaybook, no? if that's the case, how about changing AnsibleCommandConfig#hosts to 'host' (I don't see a place we provide more than a single host) and then configure the port "behind the scenes"?

I made the required changes here:
#560

@ahadas
Copy link
Member

ahadas commented Jul 31, 2022

I thought we'll need this in all places that we execute playbooks, also in places like MaintenanceVdsCommand#runAnsibleMigrationCerts and RemoveVdsCommand#runAnsibleRemovePlaybook, no? if that's the case, how about changing AnsibleCommandConfig#hosts to 'host' (I don't see a place we provide more than a single host) and then configure the port "behind the scenes"?

I made the required changes here: #560

ack, so no need for this one, right? closing

@ahadas ahadas closed this Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants