add ssh port to inventory #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangel101
requested review from
mwperina,
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
|
/ost |
|
/ost |
smelamud
requested changes
Jul 27, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java
Outdated
Show resolved
Hide resolved
ahadas
reviewed
Jul 31, 2022
There was a problem hiding this comment.
besides the comment inside on keep checking for null value of hostname, this looks great, thanks @dangel101
|
/ost |
smelamud
requested changes
Aug 1, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java
Show resolved
Hide resolved
mwperina
requested changes
Aug 2, 2022
...dules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java
Show resolved
Hide resolved
| @@ -190,14 +190,14 @@ public AnsibleReturnValue runCommand(AnsibleCommandConfig commandConfig, int tim | |||
| } | |||
|
|
|||
| private AuditLogable createAuditLogable(AnsibleCommandConfig command, String taskName) { | |||
| if (command.hosts() == null) { | |||
| if (command.host() == null) { | |||
There was a problem hiding this comment.
We can remove the check if we add a check to AnsibleExecutor.runCommand
|
/ost |
smelamud
approved these changes
Aug 3, 2022
|
Please add a description to the commit message. |
ahadas
approved these changes
Aug 3, 2022
Host validity is now verified before building the ansible-runner command, thus any operation on 'host' property is done on a non-null object
dangel101
force-pushed
the
configure_ssh_port_on_ansible_command_config
branch
from
4325c5c
to
863fbd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2104939