-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ssh port to inventory #560
add ssh port to inventory #560
Conversation
/ost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/ost |
...dules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the comment inside on keep checking for null value of hostname
, this looks great, thanks @dangel101
/ost |
...dules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java
Show resolved
Hide resolved
...dules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java
Show resolved
Hide resolved
@@ -190,14 +190,14 @@ public AnsibleReturnValue runCommand(AnsibleCommandConfig commandConfig, int tim | |||
} | |||
|
|||
private AuditLogable createAuditLogable(AnsibleCommandConfig command, String taskName) { | |||
if (command.hosts() == null) { | |||
if (command.host() == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the check if we add a check to AnsibleExecutor.runCommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/ost |
Please add a description to the commit message. |
Host validity is now verified before building the ansible-runner command, thus any operation on 'host' property is done on a non-null object
4325c5c
to
863fbd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2104939