Check expiration of ovirt-provider-ovn certificate #576
+42
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds expiration check of ovirt-provider-ovn certificate among regularly checked certificates such as engine CA, engine or hosts certificates. Bug-Url: https://bugzilla.redhat.com/2097560 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
requested review from
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
almusil
reviewed
Aug 8, 2022
...anager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java
Show resolved
Hide resolved
almusil
reviewed
Aug 8, 2022
If engine CA is going to expired, then it doesn't make sense to check other certificates, because engine CA needs to be renewed first and then all other certificates should also be renewed. Signed-off-by: Martin Perina <mperina@redhat.com>
michalskrivanek
approved these changes
Aug 8, 2022
almusil
approved these changes
Aug 8, 2022
mz-pdm
approved these changes
Aug 8, 2022
| AuditLogType.ENGINE_CERTIFICATION_HAS_EXPIRED, | ||
| AuditLogType.ENGINE_CERTIFICATION_IS_ABOUT_TO_EXPIRE_ALERT, | ||
| AuditLogType.ENGINE_CERTIFICATION_IS_ABOUT_TO_EXPIRE, | ||
| null); |
There was a problem hiding this comment.
In case the Engine certificate is already expired, maybe checking the host certificates below will fail. But exceptions look handled here, so the fact that we don't return after this check anymore shouldn't cause a real problem (and it's probably more correct because now we can warn about host certificates when the Engine certificate is going to expire).
There was a problem hiding this comment.
AFAIR VDSM is not performing client certificate checks, so even if the engine certificate is expired, engine would still be able to connect to hosts. So host certificates check should fail only when host certificate expires or going to expire.
|
/ost |
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
Aug 19, 2022
There was added an ovirt-provider-ovn certificate validity check as a part of oVirt#576 but unfortunately the path to certificate file was wrong and as this certificate is optional (it doesn't exists on setup with OVN integration disable), the certificate validity checker didn't raise any error even for setups with OVN integration enabled and ovirt-provider-ovn certificate going to expire soon. Bug-Url: https://bugzilla.redhat.com/2097560 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
that referenced
this pull request
Aug 19, 2022
There was added an ovirt-provider-ovn certificate validity check as a part of #576 but unfortunately the path to certificate file was wrong and as this certificate is optional (it doesn't exists on setup with OVN integration disable), the certificate validity checker didn't raise any error even for setups with OVN integration enabled and ovirt-provider-ovn certificate going to expire soon. Bug-Url: https://bugzilla.redhat.com/2097560 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
Aug 19, 2022
There was added an ovirt-provider-ovn certificate validity check as a part of oVirt#576 but unfortunately the path to certificate file was wrong and as this certificate is optional (it doesn't exists on setup with OVN integration disable), the certificate validity checker didn't raise any error even for setups with OVN integration enabled and ovirt-provider-ovn certificate going to expire soon. Bug-Url: https://bugzilla.redhat.com/2097560 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
that referenced
this pull request
Aug 19, 2022
There was added an ovirt-provider-ovn certificate validity check as a part of #576 but unfortunately the path to certificate file was wrong and as this certificate is optional (it doesn't exists on setup with OVN integration disable), the certificate validity checker didn't raise any error even for setups with OVN integration enabled and ovirt-provider-ovn certificate going to expire soon. Bug-Url: https://bugzilla.redhat.com/2097560 Signed-off-by: Martin Perina <mperina@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds expiration check of ovirt-provider-ovn certificate among regularly
checked certificates such as engine CA, engine or hosts certificates.
Bug-Url: https://bugzilla.redhat.com/2097560
Signed-off-by: Martin Perina mperina@redhat.com