Fix checking ovirt-provider-ovn certificate validity #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was added an ovirt-provider-ovn certificate validity check as a part of oVirt#576 but unfortunately the path to certificate file was wrong and as this certificate is optional (it doesn't exists on setup with OVN integration disable), the certificate validity checker didn't raise any error even for setups with OVN integration enabled and ovirt-provider-ovn certificate going to expire soon. Bug-Url: https://bugzilla.redhat.com/2097560 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
requested review from
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
mz-pdm
approved these changes
Aug 19, 2022
|
Verified using time shifts on engine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was added an ovirt-provider-ovn certificate validity check as
a part of #576 but
unfortunately the path to certificate file was wrong and as this
certificate is optional (it doesn't exists on setup with OVN integration
disable), the certificate validity checker didn't raise any error even
for setups with OVN integration enabled and ovirt-provider-ovn
certificate going to expire soon.
Bug-Url: https://bugzilla.redhat.com/2097560
Signed-off-by: Martin Perina mperina@redhat.com