Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveMerge: move getVolumeInfo to executeCommand #579

Merged
merged 1 commit into from
Aug 16, 2022

Commits on Aug 16, 2022

  1. core: LiveMerge: move getVolumeInfo to executeCommand

    Call to GetVolumeInfo was added to RemoveSnapshotSingleDiskLive
    command before performing the steps, in order to check if the
    Destination image (or the Top Image) exists on storage. It was added
    to the procedure, which is determining the initial merge step during
    the first run of performNextOperation.
    
    GetVolumeInfo is a synchronous call, and calling it from
    performNextOperation can block the callback thread which may block
    other commands from making progress. This change moves the procedure
    of setting the initial merge step back to executeCommand(), like it
    is in ColdMergeSnapshotSingleDisk command
    mkemel authored and ahadas committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b776cd3 View commit details
    Browse the repository at this point in the history