Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveMerge: move getVolumeInfo to executeCommand #579

Merged
merged 1 commit into from
Aug 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ protected void executeCommand() {
// Let doPolling() drive the execution; we don't have any guarantee that
// executeCommand() will finish before doPolling() is called, and we don't
// want to possibly run the first command twice.
getParameters().setCommandStep(getInitialMergeStepForImage(getParameters().getImageId()));
getParameters().setChildCommands(new HashMap<>());
setSucceeded(true); // Allow runAction to succeed
}

Expand All @@ -83,17 +85,12 @@ public boolean ignoreChildCommandFailure() {

@Override
public boolean performNextOperation(int completedChildCount) {

// Steps are executed such that:
// a) all logic before the command runs is idempotent
// b) the command is the last action in the step
// This allows for recovery after a crash at any point during command execution.

log.debug("Proceeding with execution of RemoveSnapshotSingleDiskLiveCommand");
ahadas marked this conversation as resolved.
Show resolved Hide resolved
if (getParameters().getCommandStep() == null) {
getParameters().setCommandStep(getInitialMergeStepForImage(getParameters().getImageId()));
getParameters().setChildCommands(new HashMap<>());
}

// Upon recovery or after invoking a new child command, our map may be missing an entry
syncChildCommandList(getParameters());
Expand Down