Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when changing cluster of diskless vms #634

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Fix error when changing cluster of diskless vms #634

merged 1 commit into from
Sep 11, 2022

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Sep 5, 2022 •
edited

DisksAllocationView#addDiskList wasn't prepared for getting a model
without disks sets (i.e., 'disks' is null) and since 50e0bb9 this
might happen, therefore proper handling (treating this case as if an
empty list of disks is set) is added to DisksAllocationView#addDiskList.

Bug-Url: https://bugzilla.redhat.com/2121083
Signed-off-by: Arik Hadas ahadas@redhat.com

@ahadas ahadas requested review from barpavel, bennyz and mkemel and removed request for sgratch September 5, 2022 19:37
@ahadas ahadas added the storage label Sep 5, 2022
@barpavel
Copy link
Member

barpavel commented Sep 5, 2022

DisksAllocationView#addDiskList wasn't prepared for getting a model without disks and since 50e0bb9 this might happen, therefore proper handling (treating this case as if an empty list of disks is set) is added to DisksAllocationView#addDiskList.

The problem is not the disks' absence, but that a model without disks is represented by null, maybe worth to emphasize it in commit message & PR description :)

@ahadas
webadmin: fix error when changing cluster of diskless vms
e1370f6 
DisksAllocationView#addDiskList wasn't prepared for getting a model
without disks sets (i.e., 'disks' is null) and since 50e0bb9 this
might happen, therefore proper handling (treating this case as if an
empty list of disks is set) is added to DisksAllocationView#addDiskList.

Bug-Url: https://bugzilla.redhat.com/2121083
Signed-off-by: Arik Hadas <ahadas@redhat.com>
@ahadas
Copy link
Member Author

ahadas commented Sep 11, 2022

DisksAllocationView#addDiskList wasn't prepared for getting a model without disks and since 50e0bb9 this might happen, therefore proper handling (treating this case as if an empty list of disks is set) is added to DisksAllocationView#addDiskList.

The problem is not the disks' absence, but that a model without disks is represented by null, maybe worth to emphasize it in commit message & PR description :)

emphasized :)

@ahadas
Copy link
Member Author

ahadas commented Sep 11, 2022

/ost

@ahadas ahadas merged commit aa64b26 into oVirt:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barpavel barpavel barpavel approved these changes

@ljelinkova ljelinkova Awaiting requested review from ljelinkova

@bennyz bennyz Awaiting requested review from bennyz

@mkemel mkemel Awaiting requested review from mkemel

Assignees
No one assigned
Labels
storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahadas @barpavel