Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when changing cluster of diskless vms #634

Merged
merged 1 commit into from
Sep 11, 2022
+8 −2
Merged

Fix error when changing cluster of diskless vms #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package org.ovirt.engine.ui.common.widget.uicommon.storage;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

import org.ovirt.engine.ui.common.CommonApplicationConstants;
import org.ovirt.engine.ui.common.PopupSimpleTableResources;
Expand Down Expand Up @@ -189,11 +191,15 @@ private void initListeners(final DisksAllocationModel model) {

void addDiskList(DisksAllocationModel model) {
diskListPanel.clear();
diskAllocationLabel.setVisible(!model.getDisks().isEmpty());
List<DiskModel> disks = model.getDisks();
if (disks == null) {
ahadas marked this conversation as resolved.
Show resolved Hide resolved
disks = Collections.emptyList();
}
diskAllocationLabel.setVisible(!disks.isEmpty());

int diskIndex = 0;
String columnWidth = calculateColumnWidthPercentage();
for (final DiskModel diskModel : model.getDisks()) {
for (final DiskModel diskModel : disks) {
DisksAllocationItemView disksAllocationItemView = new DisksAllocationItemView(columnWidth);
disksAllocationItemView.edit(diskModel);
disksAllocationItemView.setIsAliasChangeable(model.getIsAliasChangeable());
Expand Down