Revert "packaging: move selinux from ovirt-engine-common to ovirt-eng… #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine-setup" This reverts commit e8eee20. Moving it causes grafana on a separate machine to fail, because the plugin to enable httpd_can_network_connect is now only on the engine machine. Reverting that patch should fix that. This does not introduce a new regression, because the need for it was a mere optimization, but is now not needed anymore, as we removed use/integration of ansible-runner-service. Change-Id: I35f57983c03c2de78b16ad63d37f399db103a07b Bug-Url: https://bugzilla.redhat.com/2126778 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib
force-pushed
the
revert-move-selinux-from-ovirt-engine-common-to-ovirt-engine-setup
branch
from
f644243
to
f811c4a
Compare
|
/ost |
|
lgtm |
|
/ost |
|
Verified manually with OST [1]. It still didn't finish, but did reach test_004. I didn't include the patches for keycloak, so SSO login to grafana fails, but that's unrelated to current patch. So I think we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ine-setup"
This reverts commit e8eee20.
Change-Id: I35f57983c03c2de78b16ad63d37f399db103a07b
Bug-Url: https://bugzilla.redhat.com/2126778
Signed-off-by: Yedidyah Bar David didi@redhat.com