-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate machine basic suite master #293
Open
didib
wants to merge
5
commits into
oVirt:master
Choose a base branch
from
didib:add-separate-machine-basic-suite-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not ready for merging yet |
dc23e6d
to
3fd6a39
Compare
/ost |
6d61240
to
e3f2739
Compare
e3f2739
to
69149ec
Compare
So that it's easy to override in suites where it's not engine_fqdn. Change-Id: Id04ba872e2f7d84aa8a81a2f9c6ce4ad98bc30cf Signed-off-by: Yedidyah Bar David <didi@redhat.com>
Change-Id: I38f174d79b855c799483dd49218532a6ff13e44f Signed-off-by: Yedidyah Bar David <didi@redhat.com>
Without this, SSO login to grafana fails with this error, in keycloak.log: 2022-10-19 07:24:26,782Z WARN [org.keycloak.events] (default task-10) [] type=LOGIN_ERROR, realmId=256b7e9d-aff3-4a96-9979-85d2c07326bb, clientId=ovirt-engine-internal, userId=null, ipAddress=0:0:0:0:0:0:0:1, error=invalid_redirect_uri, redirect_uri=https://ost-separate-machine-basic-suite-master-dwh.lago.local/ovirt-engine-grafana/login/generic_oauth TODO: This should probably be done in dwh setup code or at least documented - it's not an issue specific to OST. Main obstacle, technically, is that we do not have the keycloak admin password, so ould have to ask the user, which is (at least) annoying. Change-Id: Icbdf559442da8f04c1669f574c0e401c0be4e25b Signed-off-by: Yedidyah Bar David <didi@redhat.com>
I want to use it as a simple means to make sure the engine is up. Making it loop, in a previous patch, was enough then, but now that I need the engine to be up also for test_add_dwh_to_keycloak_redirect_uris_for_grafana, that's not enough. For now, just copy it. Later, perhaps reorganize, perhaps move test_add_dwh_to_keycloak_redirect_uris_for_grafana elsewhere, etc. Change-Id: Id141160a36d360517586a0180dcc145890521687 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
Change-Id: Idbd6a9e31d724b6d03d693fe985d6405a775b9d1 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
b2eaf4e
to
525d295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.