Propagate backup mode to template disks #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
force-pushed
the
bug_779
branch
3 times, most recently
from
ced342b
to
4c0279d
Compare
Previously, all template disks were created with backup mode = NONE regardless of the backup mode of the disks of the VM that the template is created from. Now the backup mode would propagate from the VM disks to the template disks when their format is qcow2. If the template disks are created as raw their backup mode would be NONE. Enabing to create template disks with incremental backup enabled from VM disks that are raw is outside of the scope of this change. Signed-off-by: Arik Hadas <ahadas@redhat.com>
|
/ost |
bennyz
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all template disks were created with backup mode = NONE regardless of the backup mode of the disks of the VM that the template is created from.
Now the backup mode would propagte from the VM disks to the template disks when their format is qcow2. If the template disks are created as raw their backup mode would be NONE. Enabing to create template disks with incremental backup enabled from VM disks that are raw is outside of the scope of this change.