Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting value to engine config properties #791

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix setting value to engine config properties #791

merged 1 commit into from
Jan 5, 2023

Conversation

dangel101
Copy link
Member

Setting some of the properties returned an error [1]
This is a regression caused by https://bugzilla.redhat.com/show_bug.cgi?id=2089299

[1] https://lists.ovirt.org/archives/list/users@ovirt.org/message/OPH7BHGBGWMECQKRXY6GW3YGZR73JK2D/

Signed-off-by: dangel101 dangel101@gmail.com

@didib didib mentioned this pull request Jan 5, 2023
Closed
@mwperina mwperina force-pushed the fix_setting_value_to_engine_config_properties branch 2 times, most recently from f3220af to 4231463 Compare January 5, 2023 09:29
@mwperina
Copy link
Member

mwperina commented Jan 5, 2023

Now it seems to work fine for both with and without validValues options:

# engine-config -g FenceStopStatusDelayBetweenRetriesInSec
Picked up JAVA_TOOL_OPTIONS: -Dcom.redhat.fips=false
FenceStopStatusDelayBetweenRetriesInSec: 10 version: general
# engine-config -s FenceStopStatusDelayBetweenRetriesInSec=1
Picked up JAVA_TOOL_OPTIONS: -Dcom.redhat.fips=false
# engine-config -g FenceStopStatusDelayBetweenRetriesInSec
Picked up JAVA_TOOL_OPTIONS: -Dcom.redhat.fips=false
FenceStopStatusDelayBetweenRetriesInSec: 1 version: general

# engine-config -g UserSessionTimeOutInterval
Picked up JAVA_TOOL_OPTIONS: -Dcom.redhat.fips=false
UserSessionTimeOutInterval: 30 version: general
# engine-config -s UserSessionTimeOutInterval=60
Picked up JAVA_TOOL_OPTIONS: -Dcom.redhat.fips=false
# engine-config -g UserSessionTimeOutInterval
Picked up JAVA_TOOL_OPTIONS: -Dcom.redhat.fips=false
UserSessionTimeOutInterval: 60 version: general
# engine-config -s UserSessionTimeOutInterval=-1
Picked up JAVA_TOOL_OPTIONS: -Dcom.redhat.fips=false
# engine-config -g UserSessionTimeOutInterval
Picked up JAVA_TOOL_OPTIONS: -Dcom.redhat.fips=false
UserSessionTimeOutInterval: -1 version: general

@dangel101 @mwperina
fix setting value to engine config properties
c8596ba 
Setting some of the properties returned an error [1]
This is a regression caused by https://bugzilla.redhat.com/show_bug.cgi?id=2089299

[1] https://lists.ovirt.org/archives/list/users@ovirt.org/message/OPH7BHGBGWMECQKRXY6GW3YGZR73JK2D/

Signed-off-by: dangel101 <dangel101@gmail.com>
@mwperina mwperina force-pushed the fix_setting_value_to_engine_config_properties branch from 4231463 to c8596ba Compare January 5, 2023 10:19
@mwperina
Copy link
Member

mwperina commented Jan 5, 2023

/ost

@mwperina mwperina merged commit c9ffda3 into oVirt:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljelinkova ljelinkova ljelinkova left review comments

@ahadas ahadas Awaiting requested review from ahadas ahadas is a code owner

@bennyz bennyz Awaiting requested review from bennyz bennyz is a code owner

@emesika emesika Awaiting requested review from emesika emesika is a code owner

@mwperina mwperina Awaiting requested review from mwperina mwperina is a code owner

@michalskrivanek michalskrivanek Awaiting requested review from michalskrivanek michalskrivanek is a code owner

@oliel oliel Awaiting requested review from oliel

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@smelamud smelamud Awaiting requested review from smelamud smelamud is a code owner

@didib didib Awaiting requested review from didib didib is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dangel101 @mwperina @ljelinkova