Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting value to engine config properties #791

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix setting value to engine config properties #791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...end/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.List;
import java.util.Map;

import org.apache.commons.lang.StringUtils;
Expand Down Expand Up @@ -42,7 +43,13 @@ public ConfigKey generateByPropertiesKey(String key) {
if (StringUtils.isBlank(type)) {
type = "String";
}
String[] validValues = node.findValuesAsText("validValues").toArray(new String[0]);

String[] validValues = null;
List<String> parsedValue = node.findValuesAsText("validValues");
if (!parsedValue.isEmpty()) {
// not all existing options have validValues defined
validValues = parsedValue.get(0).split(",");
}

// Description containing the list delimiter *will* be broken into an array, so rejoin it using that delimiter.
// We pad the separator because the strings in the array are trimmed automatically.
Expand Down