core: Avoid NPE on refreshlun call without plugged VMs #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszomor
force-pushed
the
fix-refreshlun-npe
branch
from
72cf486
to
5d1bf92
Compare
|
Hi @bennyz |
ahadas
requested review from
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
ahadas
force-pushed
the
fix-refreshlun-npe
branch
from
d6ea311
to
478f06b
Compare
|
@ahadas Thank you! |
Signed-off-by: Laszlo Szomor <laszomor@gmail.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
force-pushed
the
fix-refreshlun-npe
branch
from
478f06b
to
863eda2
Compare
ahadas
approved these changes
May 21, 2023
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This patch fixes an NPE when running an unplugged disk's refreshlun command.
In case of refreshing an unplugged disk, the engine throws a NullPointerException. Example: npe.txt
Are you the owner of the code you are sending in, or do you have permission of the owner?
y