-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppScope Configuration #147
Conversation
cc @mikkelhegn |
b644981
to
e94c948
Compare
value: private-subnet | ||
- name: gateway-type | ||
value: nat | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add an example of HealthScope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing.
I am still waiting for more feedback from @mikkelhegn @technosophos @suhuruli to see if we all agree on this spec/model.
Once consensus is made, I will add more examples to demonstrate usability!
e94c948
to
c02cb27
Compare
A request came in that we re-do the organization of the application model so that there is an explicit ApplicationModel type that can define an entire app. It is entirely a work in progress, but I threw something together in #148 so that I can show it later this week to the various parties who requested it. Do you think we could combine this and the app model into one thing? |
I do not think app model will solve this problem. https://github.com/microsoft/hydra-spec/issues/144 and this PR is trying to solve the deployment problem. |
LGTM - did not check consistency with recent changes though... :-) |
After discussion with Matt and Sudhanva, we have agreed to not add new concept but reuse existing AppConfig. The idea is that AppConfig will define global scopes to solve such cases. I'm pulling up new PRs to make it well-written in the docs and fix the definitions as well. Thanks again for looking after it! Will ping once change is pulled up. |
As proposed in https://github.com/microsoft/hydra-spec/issues/144, this tries to define app-scope config and decouple it from AppConfig.
I have done writing the spec, but haven't decided where to put it in the page order.