Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-1032] Adding WSCG check for keys in Join #1033

Merged
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,18 @@ case class ColumnarShuffledHashJoinExec(
case _ =>
throw new UnsupportedOperationException(s"Join Type ${joinType} is not supported yet.")
}
// build check for leftKeys and rightKeys
leftKeys.union(rightKeys).foreach { expr =>
val keyExpr =
ColumnarExpressionConverter.replaceWithColumnarExpression(expr)
val supportCodegen =
keyExpr.asInstanceOf[ColumnarExpression].supportColumnarCodegen(null)
this.supportCodegen = this.supportCodegen && supportCodegen
if (!supportCodegen) {
jackylee-ch marked this conversation as resolved.
Show resolved Hide resolved
throw new UnsupportedOperationException(
"Left or Right key expressions are not fully supporting codegen!")
}
}
// build check for condition
val conditionExpr: Expression = condition.orNull
if (conditionExpr != null) {
Expand Down