Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tr 5105/sanitizer in Math pci #348

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

bziondik
Copy link
Contributor

@bziondik bziondik commented Jan 24, 2023

Related to: https://oat-sa.atlassian.net/browse/TR-5105
Converter from oat-sa/tao-core-sdk-fe#163

How to test:
create item with Math PCI, set correct answer 42
switch between Question and Response
save, see on Payload that number is sanitized to 42
image
open correct Answer - is set to 42
go to Preview, put answer 42
Submit and see that send 42
image

@github-actions
Copy link

Version

Target Version 8.7.0
Last version 8.6.5

There are 0 BREAKING CHANGE, 1 feature, 0 fix

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Nice job!

image

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

Copy link

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Good job

@bziondik bziondik merged commit e756512 into develop Jan 27, 2023
@bziondik bziondik deleted the feat/TR-5105/sanitizer-in-math-pci branch January 27, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants