Feature/TR-5014/Text converter #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
shaveko
reviewed
Dec 21, 2022
There was a problem hiding this comment.
Nice job! It's very good designed in that pluggable way.
I have doubts about merging of configs, could you please add test case to test/util/converter/factory/test.js for the case when we have two processors having same config property (what will be result of their merge).
…gistered() API instead
rgomeztao
reviewed
Dec 22, 2022
rgomeztao
approved these changes
Dec 22, 2022
rgomeztao
approved these changes
Dec 22, 2022
1 task
shaveko
approved these changes
Dec 22, 2022
2 tasks
Version
There are 0 BREAKING CHANGE, 5 features, 1 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/TR-5014
Summary
Add a text converter for sanitizing text.
This first version includes a converter for replacing ambiguous symbols with plain ASCII chars.
Details
Several components have been added:
'util/converter/factory'a converter factory, registering a list of processors for converting the text'util/converter/ambiguousSymbols'an ambiguous symbols processor for replacing Japanese number with ASCII numbers'util/converter'a default converter bundled with the builtin converted (for now only theambiguousSymbolsprocessor)Note: the list of ambiguous symbols to replace might not be finalized yet. Additions may be done soon if we get the final list.
How to test
npm cinpm testnpm run test:keepAlive