Feature/ADF-1417/Upgrade to Node 18 #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2353 +/- ##
==========================================
Coverage 16.37% 16.37%
Complexity 4207 4207
==========================================
Files 389 389
Lines 12838 12838
==========================================
Hits 2102 2102
Misses 10736 10736 |
shaveko
approved these changes
May 10, 2023
rgomeztao
approved these changes
May 10, 2023
Conflicts: views/css/qti-runner.css views/css/qti-runner.css.map views/js/loader/taoQtiItem.min.js views/js/loader/taoQtiItem.min.js.map views/js/loader/taoQtiItemRunner.es5.min.js views/js/loader/taoQtiItemRunner.es5.min.js.map views/js/loader/taoQtiItemRunner.min.js views/js/loader/taoQtiItemRunner.min.js.map views/package-lock.json views/package.json views/scss/qti/_associate.scss
Version🚨 Your pull request contains a BREAKING CHANGE, please be sure to communicate it.
There are 2 BREAKING CHANGES, 0 feature, 1 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: ADF-1417 and ADF-1418
Requires:
package.jsononce the companion PRs have been merged and releasedSummary
Update the dependencies in order to support further versions of Node
BREAKING CHANGE:
Details
To properly support Node 18, the dev dependencies had to be updated and aligned.
Note: The lock file was generated with
npm@6so it would also work seamlessly with Node 14.How to test
Note After switching to Node 18, you may need to erase the node_module folder, otherwise the error
>> Error: Could not locate the bindings filemay arise.