feature: Redesign WYSIWYG LaTeX #2646
Conversation
Front-end summary Node 18
|
There was a problem hiding this comment.
Result looks ok. The rendering of the double-arrow is a bit bad when "AB" is changed to something longer. I doubt that's fixable?
Some styling things:
In general I have concerns about editing directly mathquill.js. Can you investigate if the version in the forked repo is equivalent to mathquill.js? Perhaps it's better to update that before copying in.
| { id: 'functions', tools: ['sqrt', 'frac', 'exp', 'log', 'ln'] }, | ||
| { id: 'symbols', tools: ['e', 'infinity', 'lbrack', 'rbrack'] }, | ||
| { id: 'trigo', tools: ['pi', 'sin', 'cos'] }, | ||
| { id: 'comparison', tools: ['lte', 'gte'] }, | ||
| { id: 'operands', tools: ['times', 'divide', 'plusminus'] } |
There was a problem hiding this comment.
We have to be sure that the old ids were not used by anything (for example, is there a qtiCreator config to turn groups on or off?)
|
Updated mathquill editor, here PR: oat-sa/mathquill#7 |
taopkorczak
force-pushed
the
feature/AUT-3966/redesign-WYSIWYG-latex
branch
from
105cefc to
b1bf915
Compare
|
Now all methods are working correctly: mathquill.mov |
Version
There are 0 BREAKING CHANGE, 1 feature, 3 fixes |
|
Can be tested here: https://construct1-oat-unit01.dev.gcp-eu.taocloud.org/tao/Main/login |
| e: { label: '℮', latex: '\\mathrm{e}', fn: 'write', desc: __('Euler\'s constant') }, | ||
| infinity: { label: '∞', latex: '\\infty', fn: 'cmd', desc: __('Infinity') }, | ||
| colon: { label: ':', latex: ':', fn: 'write', desc: __('Colon') }, | ||
| lbrack: { label: '[', latex: '\\lbrack', fn: 'cmd', desc: __('Left bracket') }, | ||
| rbrack: { label: ']', latex: '\\rbrack', fn: 'cmd', desc: __('Right bracket') }, |
There was a problem hiding this comment.
When I click on [ or ], there's text not symbol in the editor:
Is it fine for you? If yes, ok, let's ignore this.
| equals: { label: '=', latex: '=', fn: 'write', desc: __('Equals') }, | ||
|
|
||
| // Comparison | ||
| equiv: { label: '≡', latex: '\\equiv', fn: 'cmd', desc: __('Equivalent') }, |
There was a problem hiding this comment.
Isn't it the wrong symbol? The upper line should be ~: https://www.compart.com/en/unicode/U+2245 and the wording should be Congruent.
| desc: __('Ray') | ||
| }, | ||
| line: { | ||
| label: '<math xmlns="http://www.w3.org/1998/Math/MathML"><mover accent="true"><mrow><mi>A</mi><mi>B</mi></mrow><mo style="margin-bottom: 0.2rem;">⸺</mo></mover></math>', |
There was a problem hiding this comment.
I'm worried about accessibility, but I don't have anything to suggest so maybe we can ignore it for now and leave it for QA.
NVDA, for overline and overparen, doesn't announce anything at all, which is pretty bad.
For other three it announces right arrow, left right arrow, right harpoon which is more or less understandable. I guess it announces the "names" of unicode symbols.
Redesign the WYSIWYG LaTeX formula editor
Symbols commonly used in Geometry items:
Triangle: △ ( not the delta symbol ∆ )
Angle: ∠
Congruent: ≅
Similar: ~
Parallel: ∥
Perpendicular: ⊥
Pi: 𝜋
Degrees: °
Alpha: 𝛼
Beta: 𝛽
Theta: 𝜃
Delta: ∆
Fractions:
Radicals:
Equations: (can be built using existing functionality)
Proportions: =
Multiplication: x
Parentheses: ( )
Colon: :
Symbols with overbars for the following geometric terms:
*Line
*Ray
*Line segment
*Arc
*Vector
Screen.Recording.2024-12-11.at.09.51.03.mov