Feature/aut 3966/redesign wysiwyg latex #7
+18,518
−7,891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently Sauce Connect actually writes some JSON stuff there upon failure: https://app.circleci.com/pipelines/github/mathquill/mathquill/92/workflows/80042bf1-3bcb-483e-8a06-41f4ccc052e6/jobs/635
ba6b23d is mistaken, it's not that Sauce Connect is writing to sauce_is_ready upon failure, it's that upon failure we're upgrading to 4.8.1 which no longer leaves the readyfile empty. This commit clears the cache (by updating the cache key [1]) and checks specifically for the error message we write to sauce_is_ready, instead of assuming Sauce Connect will leave it empty. [1]: https://circleci.com/docs/caching#clearing-cache
…wnload Bump browser-tools version
Merge in the desmos fork
MathQuill's CI system starts a server in the background by running `make server`. Previously, this would run `npm install`, which could race later ci steps that were attempting to use node modules. Fix this by adding a NO_INSTALL environment variable that tells the server not to automatically install npm dependencies.
Adding the license mentioned in README.txt so that github and other applications/tools can programmatically detect it.
Remove dead slack links
Fix npm install race in CI
Fix merge issues in unit.html
…erge Fix selection perf merge
Update README, add LICENSE
…redesign-WYSIWYG-latex
olga-kulish
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Seems to work fine for me with oat-sa/extension-tao-itemqti#2646
Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/AUT-3966
mathquill.mov