Feature/ADF-1417/Upgrade to Node 18 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 🎉
|
This was referenced Apr 26, 2023
shaveko
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
Version🚨 Your pull request contains a BREAKING CHANGE, please be sure to communicate it.
There are 1 BREAKING CHANGE, 0 feature, 0 fix |
rgomeztao
approved these changes
May 4, 2023
| schedule: | ||
| interval: "daily" | ||
| ignore: | ||
| - dependency-name: "eslint*" |
There was a problem hiding this comment.
shouldt you have a line at the end of this file? :)
There was a problem hiding this comment.
it could indeed but this is not a blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: ADF-1417 and ADF-1419
Summary
Set Node 18 for the CI workflow.
Update the devDependencies accordingly.
BREAKING CHANGE:
minimatchhas been upgraded from3.0.4to9.0.0.Details
To properly support Node 18, the dev dependencies had to be updated and aligned.
Note: The lock file was generated with
npm@6so it would also work seamlessly with Node 14.It also removes vulnerabilities 🎉
How to test
npm inpm test,npm run test:cov,npm run coveragenpm run lint